Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlockchainTests/ValidBlocks/bcStateTests/suicideStorageCheck.json #1462

Closed
FlorianHuc opened this issue Oct 29, 2024 · 2 comments
Closed

BlockchainTests/ValidBlocks/bcStateTests/suicideStorageCheck.json #1462

FlorianHuc opened this issue Oct 29, 2024 · 2 comments
Assignees
Labels
bug Something isn't working reference test

Comments

@FlorianHuc
Copy link
Collaborator

in txrlp, there is a fixed value deploymentnumber=1 here:

traceValue.codeFragmentIndex =
    chunk.tx().getTo().isEmpty() && chunk.requireEvmExecution()
        ? this.romLex.getCodeFragmentIndexByMetadata(
            ContractMetadata.make(
                Address.contractAddress(chunk.tx().getSender(), chunk.tx().getNonce()),
                1,
                true))
        : 0;

and in one test, it fails because it does not find a metadata with this deployment number (while it exist with deploymentNumber=2).
Is it expected it's not found ? In this case, we throw an error, should we use code fragment index 0 instead?

@letypequividelespoubelles
Copy link
Collaborator

I think we should use the dep number from the hub.transients.depInfo. When is it updated ? @OlivierBBB ?

@letypequividelespoubelles
Copy link
Collaborator

see #1678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working reference test
Projects
None yet
Development

No branches or pull requests

3 participants