-
Notifications
You must be signed in to change notification settings - Fork 6
feat: add test for multiple overrides config files #457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #457 +/- ##
=======================================
Coverage ? 83.25%
Complexity ? 1111
=======================================
Files ? 226
Lines ? 8003
Branches ? 624
=======================================
Hits ? 6663
Misses ? 1001
Partials ? 339
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Filter94
reviewed
Nov 6, 2025
Filter94
reviewed
Nov 6, 2025
Filter94
reviewed
Nov 6, 2025
Filter94
reviewed
Nov 6, 2025
Filter94
reviewed
Nov 6, 2025
Filter94
reviewed
Nov 6, 2025
Filter94
reviewed
Nov 10, 2025
Filter94
reviewed
Nov 10, 2025
Filter94
reviewed
Nov 10, 2025
jonesho
commented
Nov 10, 2025
Filter94
reviewed
Nov 11, 2025
Filter94
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #456
Note
Add multi-file config support to the CLI, introduce a closeable lifecycle interface and factory abstraction, and update tests accordingly.
--configto accept multiple files via comma-separated values or repeated options; update help text and parsing (split=",",arity="1..*").mixinStandardHelpOptions.MaruAppFactoryCreatorinstead of constructingMaruAppFactorydirectly.app.stop()thenapp.close(); removedryRunand related checks.LongRunningCloseable(LongRunningService+AutoCloseable).MaruAppimplementLongRunningCloseable; markstart/stopas overrides.MaruAppFactoryCreatorinterface;MaruAppFactory.create(...)now satisfies it and returnsLongRunningCloseable.MaruAppCliTestto use temp files and a fakeMaruAppFactoryCreator.Written by Cursor Bugbot for commit f7bc919. This will update automatically on new commits. Configure here.