Skip to content

Conversation

@fluentcrafter
Copy link
Collaborator

@fluentcrafter fluentcrafter commented Nov 6, 2025

Note

Make validator EL optional and wire engine/L2 ETH endpoints from ElNode via ForkTransition and updated defaults.

  • test-utils:
    • Config defaults (MaruConfigHelper.kt):
      • Add forkTransition = ForkTransition().
      • Remove default validatorElNode; now null by default.
    • Validator/EL setup:
      • setValidatorConfig is a no-op when elNode is null.
      • When present, updates validatorElNode.engineApiEndpoint and forkTransition.l2EthApiEndpoint from elNode URLs; creates ValidatorElNode if missing.
  • App factory (TestMaruAppFactory.kt):
    • Call setValidatorConfig earlier in createMaru before other config mutations.

Written by Cursor Bugbot for commit 42dfe7d. This will update automatically on new commits. Configure here.

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@be0fb67). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../main/kotlin/maru/test/cluster/MaruConfigHelper.kt 62.50% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #459   +/-   ##
=======================================
  Coverage        ?   83.00%           
  Complexity      ?     1104           
=======================================
  Files           ?      226           
  Lines           ?     7992           
  Branches        ?      624           
=======================================
  Hits            ?     6634           
  Misses          ?     1013           
  Partials        ?      345           
Flag Coverage Δ
kotlin 83.00% <64.70%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fluentcrafter fluentcrafter changed the title revert find port function Fix MaruCluster config after merge regression Nov 6, 2025
@fluentcrafter fluentcrafter merged commit 7cf92b7 into main Nov 6, 2025
22 of 24 checks passed
@fluentcrafter fluentcrafter deleted the fix-merge-errors branch November 6, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants