Skip to content

Conversation

@Filter94
Copy link
Collaborator

@Filter94 Filter94 commented Nov 6, 2025

Note

Set a default forkTransition in MaruConfig and update test configs/helpers to use forkTransition.l2EthApiEndpoint (not validatorElNode.ethApiEndpoint), with a renamed helper and added validations.

  • Config
    • Set default value for MaruConfig.forkTransition (ForkTransition()).
  • Test Utils
    • configTemplate: remove validatorElNode.ethApiEndpoint; add forkTransition.l2EthApiEndpoint.
    • Helper: rename setValidatorConfigsetElValidatorConfig; add checks requiring validatorElNode and forkTransition.l2EthApiEndpoint when ElNode is provided; update logic to set validatorElNode.engineApiEndpoint and forkTransition.l2EthApiEndpoint.
    • Factory: call setElValidatorConfig.

Written by Cursor Bugbot for commit 86b8b7c. This will update automatically on new commits. Configure here.

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
701 1 700 0
View the top 1 failed test(s) by shortest run time
maru.test.MaruClusterTest::should allow to add nodes after cluster is has started()
Stack Traces | 97.5s run time
java.lang.AssertionError: Nodes did not sync to block 2 nodes heads: {bootnode-0=(0, 0), sequencer=(90, 45), follower-internal-0=(90, 45)}
	at maru.test.extensions.MaruClusterExtensionsKt.assertNodesAreSyncedUpTo-2TYgG_w(MaruClusterExtensions.kt:27)
	at maru.test.MaruClusterTest.should_allow_to_add_nodes_after_cluster_is_has_started$lambda$0(MaruClusterTest.kt:213)
	at org.awaitility.core.AssertionCondition.lambda$new$0(AssertionCondition.java:53)
	at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:248)
	at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:235)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@Filter94 Filter94 closed this Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants