Skip to content

Conversation

@fluentcrafter
Copy link
Collaborator

@fluentcrafter fluentcrafter commented Nov 6, 2025

Note

Introduce addBesu/withBesuEl flags to optionally create a default Besu EL; require EL for sequencer nodes; update tests accordingly.

  • Cluster/Builder API:
    • Add optional addBesu/withBesuEl flags to MaruCluster.addNode(...) and createNodeBuilder(...) to control default EL (Besu) creation.
    • NodeBuilder now accepts createDefaultElBesuNode and provides withElNode(...) to inject custom EL.
    • Only auto-create Besu EL when the flag is set; add validation requiring EL for Sequencer nodes.
  • Runtime:
    • Node startup paths updated to pass EL config through and start Besu when present.
  • Tests:
    • Update tests to explicitly enable Besu for sequencer nodes and adjust expectations (e.g., sync target reduced in one case).

Written by Cursor Bugbot for commit 6032140. This will update automatically on new commits. Configure here.

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.98%. Comparing base (8064132) to head (6032140).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...s/src/main/kotlin/maru/test/cluster/NodeBuilder.kt 16.66% 3 Missing and 2 partials ⚠️
...s/src/main/kotlin/maru/test/cluster/MaruCluster.kt 81.81% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #462      +/-   ##
============================================
- Coverage     82.99%   82.98%   -0.02%     
- Complexity     1103     1108       +5     
============================================
  Files           226      226              
  Lines          7992     8003      +11     
  Branches        624      625       +1     
============================================
+ Hits           6633     6641       +8     
- Misses         1013     1021       +8     
+ Partials        346      341       -5     
Flag Coverage Δ
kotlin 82.98% <58.82%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fluentcrafter fluentcrafter merged commit 0f6dc85 into main Nov 6, 2025
10 checks passed
@fluentcrafter fluentcrafter deleted the maru-cluster-without-el branch November 6, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants