Skip to content

Conversation

@fluentcrafter
Copy link
Collaborator

@fluentcrafter fluentcrafter commented Nov 6, 2025

Note

Standardizes Maru client logger names and refactors test Log4j setup to use builder + Configurator.

  • Logging:
    • Logger names: Use maru.clients.l1.linea and maru.clients.l2.eth.el in app/src/main/kotlin/maru/app/MaruAppFactory.kt.
    • Test Log4j config (jvm-libs/test-utils/src/main/kotlin/maru/test/cluster/Configuration.kt):
      • Build console appender with pattern and SYSTEM_OUT target; attach layout directly.
      • Configure specific loggers with additivity=false and Console appender.
      • Initialize via Configurator.initialize(builder.build()) (replacing manual LoggerContext updates).

Written by Cursor Bugbot for commit 8218f3e. This will update automatically on new commits. Configure here.

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.99%. Comparing base (0f6dc85) to head (8218f3e).
⚠️ Report is 8 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/src/main/kotlin/maru/app/MaruAppFactory.kt 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #463      +/-   ##
============================================
+ Coverage     82.90%   82.99%   +0.08%     
- Complexity     1107     1109       +2     
============================================
  Files           226      226              
  Lines          8003     8003              
  Branches        625      625              
============================================
+ Hits           6635     6642       +7     
+ Misses         1026     1021       -5     
+ Partials        342      340       -2     
Flag Coverage Δ
kotlin 82.99% <84.61%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fluentcrafter fluentcrafter merged commit 6dce8bb into main Nov 8, 2025
10 checks passed
@fluentcrafter fluentcrafter deleted the fix-log-names branch November 8, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants