Reduce check argument args allocations #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
macfarla
approved these changes
Oct 14, 2024
siladu
added a commit
to siladu/besu
that referenced
this pull request
Feb 19, 2025
Includes: - reduce check argument args allocations - Consensys/tuweni#10 which should reduce Integer and int[] and therefore gc pressure Signed-off-by: Simon Dudley <[email protected]>
siladu
added a commit
to hyperledger/besu
that referenced
this pull request
Mar 17, 2025
This replaces io.tmio/tuweni with the Consensys fork. Also Includes: - reduce check argument args allocations - Consensys/tuweni#10 which should reduce Integer and int[] and therefore gc pressure Signed-off-by: Simon Dudley <[email protected]>
garyschulte
pushed a commit
to Consensys/optimism-besu
that referenced
this pull request
Apr 17, 2025
This replaces io.tmio/tuweni with the Consensys fork. Also Includes: - reduce check argument args allocations - Consensys/tuweni#10 which should reduce Integer and int[] and therefore gc pressure Signed-off-by: Simon Dudley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The checkArgument( boolean, String, ... ) causes a large number of Integer and int[] to be created temporarily on the heap which causes gc pressure. This PR adds overloads which reduces object allocations to 0 for these method calls.
Fixed Issue(s)