Skip to content

Commit bd22c20

Browse files
authored
Add missing CFBundleVersion, bump version to 0.3.1 (#74)
Using carthage to either grab the latest prebuilt binary 0.3.0 or forcing carthage to build the latest XmlCoder results in the framework's plist missing a value for CFBundleVersion, which is required for AppStore Connect upload. Other plist keys are correctly filled in. I see it's using the $(CURRENT_PROJECT_VERSION) variable for CFBundleVersion. > AppStore error: ERROR ITMS-90056: XMLCoder.framework is invalid. The Info.plist file is missing the required key: CFBundleVersion Resolves #72
1 parent 675f692 commit bd22c20

File tree

6 files changed

+22
-6
lines changed

6 files changed

+22
-6
lines changed

CHANGELOG.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,13 @@
1+
# 0.3.1 (February 6, 2019)
2+
3+
A bugfix release that adds missing `CFBundleVersion` in generated framework's
4+
`Info.plist` ([#72](https://github.com/MaxDesiatov/XMLCoder/issues/72) reported by
5+
[@stonedauwg](https://github.com/stonedauwg)).
6+
7+
## Changes
8+
9+
* Set `CURRENT_PROJECT_VERSION` in project file ([#74](https://github.com/MaxDesiatov/XMLCoder/pull/74), [@MaxDesiatov](https://github.com/MaxDesiatov))
10+
111
# 0.3.0 (January 22, 2019)
212

313
A maintenance release focused on fixing bugs, improving error reporting and

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ target 'YourApp' do
7272
use_frameworks!
7373

7474
# Pods for Test
75-
pod 'XMLCoder', '~> 0.3.0'
75+
pod 'XMLCoder', '~> 0.3.1'
7676

7777
end
7878
```
@@ -101,7 +101,7 @@ $ brew install carthage
101101
Inside of your `Cartfile`, add GitHub path to `XMLCoder`:
102102

103103
```ogdl
104-
github "MaxDesiatov/XMLCoder" ~> 0.3.0
104+
github "MaxDesiatov/XMLCoder" ~> 0.3.1
105105
```
106106

107107
Then, run the following command to build the framework:
@@ -124,7 +124,7 @@ easy as adding it to the `dependencies` value of your `Package.swift`.
124124

125125
```swift
126126
dependencies: [
127-
.package(url: "https://github.com/MaxDesiatov/XMLCoder.git", from: "0.3.0")
127+
.package(url: "https://github.com/MaxDesiatov/XMLCoder.git", from: "0.3.1")
128128
]
129129
```
130130

Sources/XMLCoder/Auxiliaries/Box/KeyedBox.swift

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
//
22
// KeyedBox.swift
3-
// XMLCoderPackageDescription
3+
// XMLCoder
44
//
55
// Created by Vincent Esche on 11/19/18.
66
//
@@ -12,6 +12,10 @@ struct KeyedStorage<Key: Hashable & Comparable, Value> {
1212

1313
fileprivate var buffer: Buffer = [:]
1414

15+
var isEmpty: Bool {
16+
return buffer.isEmpty
17+
}
18+
1519
var count: Int {
1620
return buffer.count
1721
}

Sources/XMLCoder/Decoder/XMLUnkeyedDecodingContainer.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ struct XMLUnkeyedDecodingContainer: UnkeyedDecodingContainer {
9494
if let type = type as? AnyArray.Type,
9595
let keyedBox = container
9696
.withShared({ $0[self.currentIndex] as? KeyedBox }),
97-
keyedBox.attributes.count == 0,
97+
keyedBox.attributes.isEmpty,
9898
keyedBox.elements.count == 1,
9999
let firstKey = keyedBox.elements.keys.first,
100100
let unkeyedBox = keyedBox.elements[firstKey] {

XMLCoder.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Pod::Spec.new do |s|
22
s.name = "XMLCoder"
3-
s.version = "0.3.0"
3+
s.version = "0.3.1"
44
s.summary = "XMLEncoder & XMLDecoder using the Codable protocol in Swift 4"
55
s.description = "XMLCoder allows Swift 4 Codable-conforming objects to be translated to and from XML"
66
s.homepage = "https://github.com/MaxDesiatov/XMLCoder"

XMLCoder.xcodeproj/project.pbxproj

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -654,6 +654,7 @@
654654
CLANG_ENABLE_OBJC_ARC = YES;
655655
COMBINE_HIDPI_IMAGES = YES;
656656
COPY_PHASE_STRIP = NO;
657+
CURRENT_PROJECT_VERSION = 0.3.1;
657658
DEBUG_INFORMATION_FORMAT = dwarf;
658659
DYLIB_INSTALL_NAME_BASE = "@rpath";
659660
ENABLE_NS_ASSERTIONS = YES;
@@ -683,6 +684,7 @@
683684
CLANG_ENABLE_OBJC_ARC = YES;
684685
COMBINE_HIDPI_IMAGES = YES;
685686
COPY_PHASE_STRIP = YES;
687+
CURRENT_PROJECT_VERSION = 0.3.1;
686688
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
687689
DYLIB_INSTALL_NAME_BASE = "@rpath";
688690
GCC_OPTIMIZATION_LEVEL = s;

0 commit comments

Comments
 (0)