@@ -67,7 +67,7 @@ contract ProxyAdminMultiSig is IErrors {
67
67
emit Events.Setup (msg .sender , owners, _ownersCount, threshold);
68
68
}
69
69
70
- /// @dev propose a new admin or implementation for a proxy
70
+ /// @dev proposes a new admin or implementation for a proxy
71
71
function propose (
72
72
address proxy ,
73
73
string calldata proposalType ,
@@ -94,7 +94,7 @@ contract ProxyAdminMultiSig is IErrors {
94
94
emit Events.Proposed (proposalId, proxy, proposalType, newAdminOrImplementation, data);
95
95
}
96
96
97
- /// @dev approve a pending proposal
97
+ /// @dev approves a pending proposal
98
98
function approveProposal (uint256 proposalId ) external onlyOwner {
99
99
if (! _isPendingProposal (proposalId)) {
100
100
revert NotPendingProposal ();
@@ -110,7 +110,7 @@ contract ProxyAdminMultiSig is IErrors {
110
110
emit Events.Approved (msg .sender , proposalId);
111
111
}
112
112
113
- /// @dev execute a proposal
113
+ /// @dev executes a proposal
114
114
function executeProposal (uint256 proposalId ) external onlyOwner {
115
115
Proposal storage p = _proposals[proposalId];
116
116
if (p.approvalCount < _threshold) {
@@ -135,7 +135,7 @@ contract ProxyAdminMultiSig is IErrors {
135
135
_proposals[proposalId].status = Const.STATUS_EXECUTED;
136
136
}
137
137
138
- /// @dev reject and delete a pending proposal
138
+ /// @dev rejects and delete a pending proposal
139
139
function deleteProposal (uint256 proposalId ) external onlyOwner {
140
140
if (! _isPendingProposal (proposalId)) {
141
141
revert NotPendingProposal ();
@@ -147,7 +147,7 @@ contract ProxyAdminMultiSig is IErrors {
147
147
emit Events.Deleted (msg .sender , proposalId);
148
148
}
149
149
150
- /// @dev get pending proposals
150
+ /// @dev returns pending proposals
151
151
function getPendingProposals () external view returns (Proposal[] memory results ) {
152
152
uint256 len = _pendingProposalIds.length ;
153
153
@@ -158,7 +158,7 @@ contract ProxyAdminMultiSig is IErrors {
158
158
}
159
159
}
160
160
161
- /// @dev get all proposals
161
+ /// @dev returns all proposals
162
162
function getAllProposals (uint256 offset , uint256 limit ) external view returns (Proposal[] memory results ) {
163
163
if (offset >= _proposalCount) return results;
164
164
@@ -171,7 +171,7 @@ contract ProxyAdminMultiSig is IErrors {
171
171
}
172
172
}
173
173
174
- /// @dev get wallet detail
174
+ /// @dev returns wallet detail
175
175
function getWalletDetail () external view returns (uint256 threshold , uint256 ownersCount , address [] memory owners ) {
176
176
threshold = _threshold;
177
177
ownersCount = _ownersCount;
@@ -183,12 +183,12 @@ contract ProxyAdminMultiSig is IErrors {
183
183
return _proposalCount;
184
184
}
185
185
186
- /// @dev check if an address is an owner
186
+ /// @dev checks if an address is an owner
187
187
function isOwner (address owner ) external view returns (bool ) {
188
188
return owner != Const.SENTINEL_OWNER && _owners[owner] != address (0 );
189
189
}
190
190
191
- /// @dev delete a pending proposal by proposalId
191
+ /// @dev deletes a pending proposal by proposalId
192
192
function _deletePendingProposalId (uint256 proposalId ) internal {
193
193
// find index to be deleted
194
194
uint256 index = _getPendingProposalIndex (proposalId);
@@ -205,7 +205,7 @@ contract ProxyAdminMultiSig is IErrors {
205
205
}
206
206
}
207
207
208
- /// @dev get all owners
208
+ /// @dev returns all owners
209
209
function _getOwners () internal view returns (address [] memory ) {
210
210
address [] memory array = new address [](_ownersCount);
211
211
@@ -219,7 +219,7 @@ contract ProxyAdminMultiSig is IErrors {
219
219
return array;
220
220
}
221
221
222
- /// @dev check if an owner has approved a proposal
222
+ /// @dev checks if an owner has approved a proposal
223
223
function _hasApproved (address owner , uint256 proposalId ) internal view returns (bool ) {
224
224
uint256 index = MAX_UINT256;
225
225
address [] memory approvals = _proposals[proposalId].approvals;
@@ -233,13 +233,13 @@ contract ProxyAdminMultiSig is IErrors {
233
233
return index != MAX_UINT256;
234
234
}
235
235
236
- /// @dev check if a proposal is pending
236
+ /// @dev checks if a proposal is pending
237
237
function _isPendingProposal (uint256 proposalId ) internal view returns (bool ) {
238
238
uint256 index = _getPendingProposalIndex (proposalId);
239
239
return index != MAX_UINT256;
240
240
}
241
241
242
- /// @dev get the index of a pending proposal, return MAX_UINT256 if not found,
242
+ /// @dev gets the index of a pending proposal, return MAX_UINT256 if not found,
243
243
function _getPendingProposalIndex (uint256 proposalId ) internal view returns (uint256 index ) {
244
244
index = MAX_UINT256;
245
245
for (uint256 i = 0 ; i < _pendingProposalIds.length ; i++ ) {
@@ -250,12 +250,12 @@ contract ProxyAdminMultiSig is IErrors {
250
250
}
251
251
}
252
252
253
- /// @dev Returns the smallest of two numbers.
253
+ /// @dev returns the smallest of two numbers.
254
254
function _min (uint256 a , uint256 b ) internal pure returns (uint256 ) {
255
255
return a < b ? a : b;
256
256
}
257
257
258
- /// @devReturns true if the two strings are equal.
258
+ /// @dev returns true if the two strings are equal.
259
259
function _equal (string memory a , string memory b ) internal pure returns (bool ) {
260
260
return bytes (a).length == bytes (b).length && keccak256 (bytes (a)) == keccak256 (bytes (b));
261
261
}
0 commit comments