Skip to content

Commit c14521b

Browse files
committed
feat: update comment
1 parent 8831dfa commit c14521b

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

src/ProxyAdminMultiSig.sol

+15-15
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ contract ProxyAdminMultiSig is IErrors {
6767
emit Events.Setup(msg.sender, owners, _ownersCount, threshold);
6868
}
6969

70-
/// @dev propose a new admin or implementation for a proxy
70+
/// @dev proposes a new admin or implementation for a proxy
7171
function propose(
7272
address proxy,
7373
string calldata proposalType,
@@ -94,7 +94,7 @@ contract ProxyAdminMultiSig is IErrors {
9494
emit Events.Proposed(proposalId, proxy, proposalType, newAdminOrImplementation, data);
9595
}
9696

97-
/// @dev approve a pending proposal
97+
/// @dev approves a pending proposal
9898
function approveProposal(uint256 proposalId) external onlyOwner {
9999
if (!_isPendingProposal(proposalId)) {
100100
revert NotPendingProposal();
@@ -110,7 +110,7 @@ contract ProxyAdminMultiSig is IErrors {
110110
emit Events.Approved(msg.sender, proposalId);
111111
}
112112

113-
/// @dev execute a proposal
113+
/// @dev executes a proposal
114114
function executeProposal(uint256 proposalId) external onlyOwner {
115115
Proposal storage p = _proposals[proposalId];
116116
if (p.approvalCount < _threshold) {
@@ -135,7 +135,7 @@ contract ProxyAdminMultiSig is IErrors {
135135
_proposals[proposalId].status = Const.STATUS_EXECUTED;
136136
}
137137

138-
/// @dev reject and delete a pending proposal
138+
/// @dev rejects and delete a pending proposal
139139
function deleteProposal(uint256 proposalId) external onlyOwner {
140140
if (!_isPendingProposal(proposalId)) {
141141
revert NotPendingProposal();
@@ -147,7 +147,7 @@ contract ProxyAdminMultiSig is IErrors {
147147
emit Events.Deleted(msg.sender, proposalId);
148148
}
149149

150-
/// @dev get pending proposals
150+
/// @dev returns pending proposals
151151
function getPendingProposals() external view returns (Proposal[] memory results) {
152152
uint256 len = _pendingProposalIds.length;
153153

@@ -158,7 +158,7 @@ contract ProxyAdminMultiSig is IErrors {
158158
}
159159
}
160160

161-
/// @dev get all proposals
161+
/// @dev returns all proposals
162162
function getAllProposals(uint256 offset, uint256 limit) external view returns (Proposal[] memory results) {
163163
if (offset >= _proposalCount) return results;
164164

@@ -171,7 +171,7 @@ contract ProxyAdminMultiSig is IErrors {
171171
}
172172
}
173173

174-
/// @dev get wallet detail
174+
/// @dev returns wallet detail
175175
function getWalletDetail() external view returns (uint256 threshold, uint256 ownersCount, address[] memory owners) {
176176
threshold = _threshold;
177177
ownersCount = _ownersCount;
@@ -183,12 +183,12 @@ contract ProxyAdminMultiSig is IErrors {
183183
return _proposalCount;
184184
}
185185

186-
/// @dev check if an address is an owner
186+
/// @dev checks if an address is an owner
187187
function isOwner(address owner) external view returns (bool) {
188188
return owner != Const.SENTINEL_OWNER && _owners[owner] != address(0);
189189
}
190190

191-
/// @dev delete a pending proposal by proposalId
191+
/// @dev deletes a pending proposal by proposalId
192192
function _deletePendingProposalId(uint256 proposalId) internal {
193193
// find index to be deleted
194194
uint256 index = _getPendingProposalIndex(proposalId);
@@ -205,7 +205,7 @@ contract ProxyAdminMultiSig is IErrors {
205205
}
206206
}
207207

208-
/// @dev get all owners
208+
/// @dev returns all owners
209209
function _getOwners() internal view returns (address[] memory) {
210210
address[] memory array = new address[](_ownersCount);
211211

@@ -219,7 +219,7 @@ contract ProxyAdminMultiSig is IErrors {
219219
return array;
220220
}
221221

222-
/// @dev check if an owner has approved a proposal
222+
/// @dev checks if an owner has approved a proposal
223223
function _hasApproved(address owner, uint256 proposalId) internal view returns (bool) {
224224
uint256 index = MAX_UINT256;
225225
address[] memory approvals = _proposals[proposalId].approvals;
@@ -233,13 +233,13 @@ contract ProxyAdminMultiSig is IErrors {
233233
return index != MAX_UINT256;
234234
}
235235

236-
/// @dev check if a proposal is pending
236+
/// @dev checks if a proposal is pending
237237
function _isPendingProposal(uint256 proposalId) internal view returns (bool) {
238238
uint256 index = _getPendingProposalIndex(proposalId);
239239
return index != MAX_UINT256;
240240
}
241241

242-
/// @dev get the index of a pending proposal, return MAX_UINT256 if not found,
242+
/// @dev gets the index of a pending proposal, return MAX_UINT256 if not found,
243243
function _getPendingProposalIndex(uint256 proposalId) internal view returns (uint256 index) {
244244
index = MAX_UINT256;
245245
for (uint256 i = 0; i < _pendingProposalIds.length; i++) {
@@ -250,12 +250,12 @@ contract ProxyAdminMultiSig is IErrors {
250250
}
251251
}
252252

253-
/// @dev Returns the smallest of two numbers.
253+
/// @dev returns the smallest of two numbers.
254254
function _min(uint256 a, uint256 b) internal pure returns (uint256) {
255255
return a < b ? a : b;
256256
}
257257

258-
/// @devReturns true if the two strings are equal.
258+
/// @dev returns true if the two strings are equal.
259259
function _equal(string memory a, string memory b) internal pure returns (bool) {
260260
return bytes(a).length == bytes(b).length && keccak256(bytes(a)) == keccak256(bytes(b));
261261
}

0 commit comments

Comments
 (0)