Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zlib HTTP compression #46

Closed
The-EDev opened this issue Nov 9, 2020 · 2 comments · Fixed by #93
Closed

Zlib HTTP compression #46

The-EDev opened this issue Nov 9, 2020 · 2 comments · Fixed by #93
Assignees
@The-EDev
Labels
feature Code based project improvement
Milestone
v0.3

Comments

@The-EDev
Copy link
Member

The-EDev commented Nov 9, 2020 •
edited
Loading

ipkn#144

Should support compression and decompression for http requests.

This could be needed before HTTP/2 could be implemented.
@The-EDev The-EDev added the feature Code based project improvement label Nov 9, 2020
@The-EDev The-EDev added this to the v0.3 milestone Nov 13, 2020
@The-EDev
Copy link
Member Author

The first PR seems good, but is a middleware, which might not workout since I believe header compression is part of HTTP/2.

The second is not middleware but only runs on websockets.

@mrozigor
Copy link
Member

I think that compression should be enabled by default, as a part of framework. Maybe it should be option to disable it from configuration file?

@The-EDev The-EDev self-assigned this Dec 27, 2020
@The-EDev The-EDev changed the title Zlib compression Zlib HTTP compression Jan 1, 2021
@The-EDev The-EDev mentioned this issue Jan 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@The-EDev The-EDev

Labels
feature Code based project improvement
Projects
None yet
Milestone
v0.3
Development

Successfully merging a pull request may close this issue.

Added HTTP compression using gzip or deflate CrowCpp/Crow
2 participants
@mrozigor @The-EDev