Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating Point Errors #1095

Open
S0ly opened this issue Jan 5, 2025 · 0 comments · May be fixed by #1211
Open

Floating Point Errors #1095

S0ly opened this issue Jan 5, 2025 · 0 comments · May be fixed by #1211
Labels
High Priority Critical. Act quickly for resolution

Comments

@S0ly
Copy link
Member

S0ly commented Jan 5, 2025

What is your request about?

currently the panel is using floats for lots of things, this could become a very big problems
most of the banking system avoid to use floats

a refactor should be aiming to fix this issue

ethier by reworking everything (best but slow)

  • Database - Store as integers (cents)
  • Application logic - All calculations must use integers
  • UI - Display as floats but handle all input as integers

or by doing a quick fix (quick but bad)

  • bcmath on all application logic

Branch

main

Solution idea

No response

CtrlPanel Logs

No response

Additional Info

No response

@S0ly S0ly added Bug / Fix High Priority Critical. Act quickly for resolution labels Jan 5, 2025
@MrWeez MrWeez removed the Bug / Fix label Feb 21, 2025
@Ferks-FK Ferks-FK linked a pull request Mar 29, 2025 that will close this issue
2 tasks
@S0ly S0ly linked a pull request Mar 30, 2025 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority Critical. Act quickly for resolution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants