Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark mode claims a decompression error on this data w/huf #102

Open
adamdmoss opened this issue Jul 17, 2020 · 5 comments
Open

benchmark mode claims a decompression error on this data w/huf #102

adamdmoss opened this issue Jul 17, 2020 · 5 comments

Comments

@adamdmoss
Copy link

 % ./fse -h -b ./xxx    
FSE : Finite State Entropy, 64-bits demo by Yann Collet (Jul 17 2020)
!! Error decompressing block 4 of cSize 18041 !! => (Corrupted block detected)

gunzip the below file and run the above.
xxx.gz
The 'xxx' file appears to survive a huf compress and then a huf decompress intact when doing them individually, so perhaps this is an issue specific to the benchmark mode.

Tested with 3865a70

@adamdmoss
Copy link
Author

 % cc --version
cc (Ubuntu 8.4.0-1ubuntu1~18.04) 8.4.0
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

@adamdmoss
Copy link
Author

adamdmoss commented Jul 17, 2020

also occurs with:

 % clang --version
clang version 9.0.0-2~ubuntu18.04.2 (tags/RELEASE_900/final)
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

... so I suppose, not a compiler issue.

@adamdmoss
Copy link
Author

Oh, yikes, might be a dupe of #95 ... except this repro data is tiny. :)

@Cyan4973
Copy link
Owner

Cyan4973 commented Jul 17, 2020

I think the issue is that the xxx file is > 128 KB.

The huffman format requires input data to be provided in blocks <= 128 KB.
When it's longer than that, it must be split accordingly.
Splitting is performed by the I/O layer, but is not present in the benchmark module.

Nevertheless, while there is a explanation, it underlines that the information message is not clear enough about the root cause.

@adamdmoss
Copy link
Author

Ah! That was really unobvious. Thanks for the explanation. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants