Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latch~ velocity logic causes clicks #5

Open
starakaj opened this issue Oct 13, 2022 · 0 comments
Open

latch~ velocity logic causes clicks #5

starakaj opened this issue Oct 13, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@starakaj
Copy link
Contributor

Screen Shot 2022-10-13 at 2 21 25 PM

This logic causes clicks. If a new note on comes in while the old note is still in release, then the envelope will suddenly be scaled to a new velocity, causing an audible click. Subtractive synth preset 4 is a great way to hear this. This envelope-scaling logic needs to be baked into the envelope somehow for this to be correct. Just adding a slide~ after the latch~ would get rid of the click but cause a different issue.

@benbrackenc74 benbrackenc74 added the bug Something isn't working label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants