Skip to content

Commit 61fd1e4

Browse files
committed
Enable testings using HTTPS on macOS
1 parent b03d83e commit 61fd1e4

12 files changed

+35
-248
lines changed

test/YetAnotherHttpHandler.Test/Helpers/Testing/ConditionalFactAttribute.cs

-14
This file was deleted.

test/YetAnotherHttpHandler.Test/Helpers/Testing/ConditionalFactDiscoverer.cs

-27
This file was deleted.

test/YetAnotherHttpHandler.Test/Helpers/Testing/ITestCondition.cs

-11
This file was deleted.

test/YetAnotherHttpHandler.Test/Helpers/Testing/OSSkipConditionAttribute.cs

-62
This file was deleted.

test/YetAnotherHttpHandler.Test/Helpers/Testing/OperatingSystems.cs

-14
This file was deleted.

test/YetAnotherHttpHandler.Test/Helpers/Testing/SkippedTestCase.cs

-49
This file was deleted.

test/YetAnotherHttpHandler.Test/Helpers/Testing/TestMethodExtensions.cs

-33
This file was deleted.

test/YetAnotherHttpHandler.Test/Http1Test.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public async Task FailedToConnect_VersionMismatch()
4141
Assert.Contains("'HTTP_1_1_REQUIRED' (0xd)", ex.Message);
4242
}
4343

44-
[ConditionalFact]
44+
[Fact]
4545
public async Task Request_Version_20_Http1OnlyServer_Secure()
4646
{
4747
// Arrange

test/YetAnotherHttpHandler.Test/Http2Test.cs

+6-7
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
namespace _YetAnotherHttpHandler.Test;
1010

11-
[OSSkipCondition(OperatingSystems.MacOSX)] // .NET 7 or earlier does not support ALPN on macOS.
1211
public class Http2Test(ITestOutputHelper testOutputHelper) : Http2TestBase(testOutputHelper)
1312
{
1413
protected override YetAnotherHttpHandler CreateHandler()
@@ -39,7 +38,7 @@ protected override Task<TestWebAppServer> LaunchServerAsyncCore<T>(Action<WebApp
3938
});
4039
}
4140

42-
[ConditionalFact]
41+
[Fact]
4342
public async Task SelfSignedCertificate_NotTrusted()
4443
{
4544
// Arrange
@@ -55,7 +54,7 @@ public async Task SelfSignedCertificate_NotTrusted()
5554
Assert.IsType<HttpRequestException>(ex);
5655
}
5756

58-
[ConditionalFact]
57+
[Fact]
5958
public async Task SelfSignedCertificate_NotTrusted_SkipValidation()
6059
{
6160
// Arrange
@@ -72,7 +71,7 @@ public async Task SelfSignedCertificate_NotTrusted_SkipValidation()
7271
Assert.Equal("__OK__", result);
7372
}
7473

75-
[ConditionalFact]
74+
[Fact]
7675
public async Task SelfSignedCertificate_Trusted_CustomRootCA()
7776
{
7877
// Arrange
@@ -94,7 +93,7 @@ public async Task SelfSignedCertificate_Trusted_CustomRootCA()
9493
Assert.Equal("__OK__", result);
9594
}
9695

97-
[ConditionalFact]
96+
[Fact]
9897
public async Task CustomCertificateVerificationHandler_Success()
9998
{
10099
// Arrange
@@ -118,7 +117,7 @@ public async Task CustomCertificateVerificationHandler_Success()
118117
Assert.Equal("__OK__", result);
119118
}
120119

121-
[ConditionalFact]
120+
[Fact]
122121
public async Task CustomCertificateVerificationHandler_Failure()
123122
{
124123
// Arrange
@@ -141,7 +140,7 @@ public async Task CustomCertificateVerificationHandler_Failure()
141140
Assert.IsType<HttpRequestException>(ex);
142141
}
143142

144-
[ConditionalFact]
143+
[Fact]
145144
public async Task CustomCertificateVerificationHandler_Certificate()
146145
{
147146
// Arrange

0 commit comments

Comments
 (0)