Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some suggestions/feature requests #13

Open
sk1418 opened this issue Jun 8, 2021 · 2 comments
Open

some suggestions/feature requests #13

sk1418 opened this issue Jun 8, 2021 · 2 comments

Comments

@sk1418
Copy link

sk1418 commented Jun 8, 2021

I've made the application run in docker. After I imported my clips.txt and tested it in the browser, I like it pretty much.
After my short testing, come up with a few suggestions, you can consider them, it would be great if you can apply some of them:

  • Function: import works well! nice. however, re-import is required after reloading the page. I guess this is because it converted the content and saved it in the memory. Could we save the converted data (json? very likely) somewhere? If the goal of the app is only personal usage, I guess we can consider re-creating the json after each new import.
  • Function: It would be great if there is font-size option.
  • UI: book list and clips side by side is nice, I like it. However, could you please make the splitter selectable/moveable so that we can adjust the two frames to have a different proportion than 50%:50%?
  • UI: Is it possible to provide a list view of the books? In case one had many books, it's a bit inconvenient to find the right one.
  • UI: Do you think it's ok to make the header of the page "Books (number)" "upload area" and the "title -- x Clips" smaller? right now they're using about 25% of the browser window height

I like your application. I wish I could contribute to the nice project....
Probably, it encourages me to learn some javascript :-D
Thank you

@sk1418
Copy link
Author

sk1418 commented Jun 8, 2021

oh... most important, I think you may want to design a logo of the application and put the logo somewhere on the webpage linking to this repository. ^_^

@D3vd
Copy link
Owner

D3vd commented Jun 8, 2021

Thanks for all the suggestions! These are great. I built this over a year ago over a short span of time and I didn't really put that much thought into it 😛

I really want to implement all the suggestions that you brought up, but I am not sure if I will have the time to do so. Feel free contribute if you can, I will be glad to check out your PR.
I will try to work on these when I get time. I will keep this issue open until then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants