Merged
Conversation
honghoker
requested changes
Dec 21, 2025
Member
honghoker
left a comment
honghoker
left a comment
There was a problem hiding this comment.
프리뷰 드디어 되는구나! 👍
코멘트 확인하고 수정해줘! 고생 많았어~!
| @@ -1,2 +1,2 @@ | |||
| [tools] | |||
| tuist = "4.45.1" | |||
| tuist = "4.113.0" | |||
Comment on lines
+46
to
+58
| EmptyReducer() | ||
| .ifCaseLet(\.splash, action: \.view.splash) { | ||
| Splash() | ||
| } | ||
| .ifCaseLet(\.auth, action: \.view.auth) { | ||
| AuthCoordinator() | ||
| } | ||
| .ifCaseLet(\.coreMember, action: \.view.coreMember) { | ||
| StaffCoordinator() | ||
| } | ||
| .ifCaseLet(\.member, action: \.view.member) { | ||
| MemberCoordinator() | ||
| } |
Member
There was a problem hiding this comment.
리듀서 체인을 자식 리듀서 -> 부모 리듀서 순서로 변경했네!
자식 리듀서가 액션을 먼저 처리하고 부모 리듀서에서 상태 갱신을 하기 때문에 이벤트 손실될 가능성이 줄어들어서 좋은 것 같아!
Comment on lines
+12
to
+14
| case none | ||
| case apple | ||
| case google |
Member
There was a problem hiding this comment.
우리가 apple과 google 소셜 로그인만 고정으로 지원하기 때문에 none 케이스는 불필요해보여.
LoginView에서도 CaseIterable를 통해 .none을 필터링해서 사용하고 있고, 다른 영역에서도 사용하는 곳이 없어서 제거하는게 좋을 것 같아!
Comment on lines
+12
to
+16
| public protocol AppleAuthRequestPreparing { | ||
| func prepare(_ request: ASAuthorizationAppleIDRequest) -> String | ||
| } | ||
|
|
||
| public struct AppleLoginManager: AppleAuthRequestPreparing { |
Member
There was a problem hiding this comment.
싱글톤에서 의존성 주입을 할 수 있도록 변경됐구나!
사용하는 곳에선 여전히 구현체를 직접 사용하고 있어서 나중에 의존성 주입을 받아서 사용하도록 수정하면 더 좋을 것 같아!
| .SPM.firebaseFirestore, | ||
| .SPM.composableArchitecture | ||
|
|
||
| .Shared(implements: .ThirdParty) |
Member
There was a problem hiding this comment.
Network/ThirdPartys가 Shared/ThirdParty에 의존하면 네트워크 레이어가 사실상 앱 전체 서드파티에 접근 가능한 구조가 돼. Network에서 필요한 라이브러리만 별도로 선언하는 방향이 더 좋을 것 같아!
Roy-wonji
added a commit
that referenced
this pull request
Feb 20, 2026
* 🔧[refactor]: Apple/Google 소셜 로그인 구조 개선 및 컴포넌트 분리 * 🔧[refactor]: 동적 링킹 지원 및 프리뷰 개선 * 🔧[refactor]: SocialType enum 정리 및 프리뷰 빌드 개선 * 🔧[refactor]: Network 모듈 의존성 경로 수정
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 주요 내용
🎨 소셜 로그인 UI 개선
🔧 SwiftUI Preview 안정화
📦 의존성 관리 개선