Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gps "texture" compound #789

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Remove gps "texture" compound #789

merged 1 commit into from
Jul 17, 2024

Conversation

quietust
Copy link
Member

because its very existence causes alignment errors on Windows.

Also fix the texture_indices lengths so they're hopefully correct.

because its very existence causes alignment errors on Windows.

Also fix the texture_indices lengths so they're correct.
Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any references in the scripts, so if this passes ci, then it's good to merge

Copy link
Contributor

The sizes of the following types have changed in this pull request. Please verify that this is intentional. Note that renamed types are not currently detected and will also be listed here.

Type Platform Previous size New size (this PR) Change
graphic linux64 223040 226736 +3696
graphic windows64 222224 225912 +3688

This is an automated comment. Please leave a reply if you think that the above information is incorrect.

@quietust
Copy link
Member Author

quietust commented Jul 17, 2024

According to the globals table in the EXE, the correct size of graphicst on Windows is 0x37278, or 225912.
And the correct size on Linux is 0x375b0, or 226736.

Conveniently, both of these numbers match the "new size" values in the table above.

@quietust quietust merged commit 3b02907 into DFHack:master Jul 17, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants