avatar property sort #2525
Merged
avatar property sort #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
A PR aimed at sorting avatar properties while refactoring and enhancing various components across the codebase. Key changes include:
- Adding a Process extension method to check if a process is running.
- Refactoring exception service components (attachments and fingerprints) and updating logging telemetry with Sentry integrations.
- Updating the CalculableAvatar model and related interfaces as well as improving HTTP download error handling and WebView2 version management.
Reviewed Changes
Copilot reviewed 163 out of 163 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Extension/ProcessExtension.cs | Introduces an extension method for Process to check its running state. |
| Core/ExceptionService/ExceptionAttachment.cs | Adds methods to set and retrieve Sentry attachments using a ConditionalWeakTable. |
| Core/ExceptionService/ExceptionFingerprint.cs | Implements fingerprint management for exceptions using a ConditionalWeakTable. |
| Model/Intrinsic/PlatformType.cs | Extends the PlatformType enum with additional platform identifiers. |
| Core/Logging/LoggerFactoryExtension.cs | Updates logging telemetry configuration, adding new sampling and profiling integrations. |
| Model/Calculable/CalculableAvatar.cs | Reorders and adds properties related to avatar promotion logic. |
| Model/Metadata/Converter/BaseValueInfoConverter.cs | Refactors methods for calculating promotion status from avatar levels. |
| Model/Calculable/ICalculableAvatar.cs | Extends the avatar interface with new promotion-related properties. |
| Core/Threading/TaskContext.cs | Replaces the dispatcher synchronization context with a private implementation. |
| Model/Entity/SettingEntry.Constant.cs | Adds new constants and marks older ones obsolete to align with updated feature flags. |
| Core/ExceptionService/ExceptionHResultProcessor.cs | Refines exception processing by removing nullable entries and updating mechanism data. |
| Core/LifeCycle/AppActivation.cs | Renames service resolution from the old Sentry IP configurator to the new Sentry IP traits. |
| Core/Caching/ImageCacheDownloadOperation.cs | Improves HTTP download error handling by refactoring client scope and retry logic. |
| Core/WebView2Version.cs | Modifies the WebView2Version struct to include a raw version string in its constructor. |
| Core/LifeCycle/SentryIpAddressTraits.cs | Renames and refactors the service for configuring Sentry IP address traits. |
| Model/Metadata/Monster/MonsterRelationship.cs | Adds a new mapping entry for a specific monster relationship id. |
src/Snap.Hutao/Snap.Hutao/Core/ExceptionService/ExceptionAttachment.cs
Outdated
Show resolved
Hide resolved
src/Snap.Hutao/Snap.Hutao/Core/ExceptionService/ExceptionFingerprint.cs
Outdated
Show resolved
Hide resolved
qhy040404
commented
Mar 12, 2025
src/Snap.Hutao/Snap.Hutao/ViewModel/AvatarProperty/AvatarView.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
close #2512
Checklist
developbranch