You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I started cleaning the GUI destruction process in #433. Yet, there are still some aspects that I don't like:
The prepare_destruction method of the MainWindowController calls self.destroy(), which then recursively destroys the whole GUI. This is not a prepare, but a full destroy. Especially, because this also triggers MenuBarController's on_destroy, which stops the gtk main loop.
Many functionalities (see on_quit_activate, on_delete_event, on_destroy) is handled in the MenuBarController. I think, the GUI should work without this controller. Thus, this code should be moved probably to the MainWindowController
Originally created by @franzlst ([email protected]) at 2017-11-22 08:56:28+00:00 (moved from RMC internal repository)
This discussion was converted from issue #434 on December 13, 2024 12:15.
Heading
Bold
Italic
Quote
Code
Link
Numbered list
Unordered list
Task list
Attach files
Mention
Reference
Menu
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I started cleaning the GUI destruction process in #433. Yet, there are still some aspects that I don't like:
prepare_destruction
method of theMainWindowController
callsself.destroy()
, which then recursively destroys the whole GUI. This is not a prepare, but a full destroy. Especially, because this also triggersMenuBarController
'son_destroy
, which stops the gtk main loop.on_quit_activate
,on_delete_event
,on_destroy
) is handled in theMenuBarController
. I think, the GUI should work without this controller. Thus, this code should be moved probably to theMainWindowController
Originally created by @franzlst ([email protected]) at 2017-11-22 08:56:28+00:00 (moved from RMC internal repository)
Beta Was this translation helpful? Give feedback.
All reactions