Fix tests when zip strict is not needed

Author: araffin

tests/test_cnn.py

@@ -9,7 +9,6 @@
 from stable_baselines3 import A2C, DQN, PPO, SAC, TD3
 from stable_baselines3.common.envs import FakeImageEnv
 from stable_baselines3.common.preprocessing import is_image_space, is_image_space_channels_first
-from stable_baselines3.common.utils import zip_strict
 from stable_baselines3.common.vec_env import DummyVecEnv, VecFrameStack, VecNormalize, VecTransposeImage, is_vecenv_wrapped
 
 
@@ -102,26 +101,26 @@ def patch_dqn_names_(model):
 
 
 def params_should_match(params, other_params):
-    for param, other_param in zip_strict(params, other_params):
+    for param, other_param in zip(params, other_params, strict=True):
         assert th.allclose(param, other_param)
 
 
 def params_should_differ(params, other_params):
-    for param, other_param in zip_strict(params, other_params):
+    for param, other_param in zip(params, other_params, strict=True):
         assert not th.allclose(param, other_param)
 
 
 def check_td3_feature_extractor_match(model):
     for (key, actor_param), critic_param in zip(
-        model.actor_target.named_parameters(), model.critic_target.parameters(), strict=True
+        model.actor_target.named_parameters(), model.critic_target.parameters(), strict=False
     ):
         if "features_extractor" in key:
             assert th.allclose(actor_param, critic_param), key
 
 
 def check_td3_feature_extractor_differ(model):
     for (key, actor_param), critic_param in zip(
-        model.actor_target.named_parameters(), model.critic_target.parameters(), strict=True
+        model.actor_target.named_parameters(), model.critic_target.parameters(), strict=False
     ):
         if "features_extractor" in key:
             assert not th.allclose(actor_param, critic_param), key