Add TODO

araffin · araffin · commit cd362eae88c3 · 2025-06-06T18:09:50.000+02:00
diff --git a/stable_baselines3/common/buffers.py b/stable_baselines3/common/buffers.py
@@ -939,5 +939,6 @@ def _get_samples(self, batch_inds: np.ndarray, env: Optional[VecNormalize] = Non
             actions=self.to_torch(actions),
             next_observations=self.to_torch(next_obs),  # type: ignore[arg-type]
             dones=self.to_torch(final_dones),
+            # FIXME: what to do with self._normalize_reward ?
             rewards=self.to_torch(n_step_returns),
         )

Original file line number	Diff line number	Diff line change
`@@ -939,5 +939,6 @@ def _get_samples(self, batch_inds: np.ndarray, env: Optional[VecNormalize] = Non`
`939`	`939`	`actions=self.to_torch(actions),`
`940`	`940`	`next_observations=self.to_torch(next_obs), # type: ignore[arg-type]`
`941`	`941`	`dones=self.to_torch(final_dones),`
	`942`	`+ # FIXME: what to do with self._normalize_reward ?`
`942`	`943`	`rewards=self.to_torch(n_step_returns),`
`943`	`944`	`)`