Skip to content

Commit 6765854

Browse files
authored
Merge pull request #4 from billdodd/updates-2.9
Update playbooks to match Ansible 2.9 stable release
2 parents c97b2cc + c0b3ba3 commit 6765854

28 files changed

+122
-26
lines changed

OEM_EXTENSIONS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ This document describes an approach for extending the standard Redfish Ansible m
88

99
## The Approach
1010

11-
With the current Redfish Ansible support, there are three main modules (`redfish_command.py`, `redfish_config.py` and `redfish_facts.py`). These three modules are relatively thin modules that establish the commands and their parameters and then call out to a utility module, `redfish_utils.py`, that has the bulk of the logic to interact with the Redfish services.
11+
With the current Redfish Ansible support, there are three main modules (`redfish_command.py`, `redfish_config.py` and `redfish_info.py`). These three modules are relatively thin modules that establish the commands and their parameters and then call out to a utility module, `redfish_utils.py`, that has the bulk of the logic to interact with the Redfish services.
1212

1313
The `redfish_utils.py` module implements a `RedfishUtils` class that has many methods to perform the various Redfish operations. With this architecture, a new vendor module that needs to add a specific Oem feature can create a new class (e.g. `ContosoRedfishUtils`) that extends the existing `RedfishUtils`. New method(s) can be added to that class (or existing methods overridden) while still being able to leverage all the existing standard methods in the parent class. Then a new vendor module (e.g. `contoso_redfish_command.py`) can be written that is basically a sparse version of `redfish_command.py` that only needs to handle the new or changed vendor commands.
1414

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ This repository contains a set of example Ansible playbooks for invoking the Red
88

99
## Prerequisites
1010

11-
To use these playbooks, you first need to install Ansible (version 2.7 or later; preferably version 2.8 or later). The Redfish Ansible modules are included in the Ansible distribution. Instructions for installing Ansible can be found here:
11+
To use these playbooks, you first need to install the latest stable release of Ansible (currently version 2.9). The Redfish Ansible modules are included in the Ansible distribution. Instructions for installing Ansible can be found here:
1212

1313
[Ansible Installation Guide](https://docs.ansible.com/ansible/latest/installation_guide/intro_installation.html)
1414

@@ -40,9 +40,9 @@ The three Redfish modules are summarized here:
4040

4141
The `redfish_config` module performs OOB controller operations like setting the BIOS configuration.
4242

43-
3. [redfish_facts](https://docs.ansible.com/ansible/latest/modules/redfish_facts_module.html) (source: [redfish_facts.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/remote_management/redfish/redfish_facts.py))
43+
3. [redfish_info](https://docs.ansible.com/ansible/devel/modules/redfish_info_module.html) (source: [redfish_info.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/remote_management/redfish/redfish_info.py))
4444

45-
The `redfish_facts` module retrieves information about the OOB controller like Systems inventory and Accounts inventory.
45+
The `redfish_info` module retrieves information about the OOB controller like Systems inventory and Accounts inventory.
4646

4747
All three of the above modules use this utility module: [redfish_utils.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/redfish_utils.py)
4848

playbooks/accounts/list_users.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
include_tasks: create_output_file.yml
1414

1515
- name: List all users
16-
redfish_facts:
16+
redfish_info:
1717
category: Accounts
1818
command: ListUsers
1919
baseuri: "{{ baseuri }}"

playbooks/chassis/get_chassis_inventory.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
include_tasks: create_output_file.yml
1414

1515
- name: Get chassis Inventory
16-
redfish_facts:
16+
redfish_info:
1717
category: Chassis
1818
command: GetChassisInventory
1919
baseuri: "{{ baseuri }}"

playbooks/chassis/get_chassis_power.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
include_tasks: create_output_file.yml
1414

1515
- name: Get chassis power
16-
redfish_facts:
16+
redfish_info:
1717
category: Chassis
1818
command: GetChassisPower
1919
baseuri: "{{ baseuri }}"

playbooks/chassis/get_chassis_thermals.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
include_tasks: create_output_file.yml
1414

1515
- name: Get chassis thermals
16-
redfish_facts:
16+
redfish_info:
1717
category: Chassis
1818
command: GetChassisThermals
1919
baseuri: "{{ baseuri }}"

playbooks/chassis/get_fan_inventory.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
include_tasks: create_output_file.yml
1414

1515
- name: Get fans statistics
16-
redfish_facts:
16+
redfish_info:
1717
category: Chassis
1818
command: GetFanInventory
1919
baseuri: "{{ baseuri }}"

playbooks/chassis/get_psu_inventory.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
include_tasks: create_output_file.yml
1414

1515
- name: Get PSU Inventory
16-
redfish_facts:
16+
redfish_info:
1717
category: Chassis
1818
command: GetPsuInventory
1919
baseuri: "{{ baseuri }}"

playbooks/manager/get_manager_logs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
include_tasks: create_output_file.yml
1414

1515
- name: Get Manager Logs
16-
redfish_facts:
16+
redfish_info:
1717
category: Manager
1818
command: GetLogs
1919
baseuri: "{{ baseuri }}"

playbooks/manager/get_manager_nic_inventory.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
include_tasks: create_output_file.yml
1414

1515
- name: Get Manager NIC inventory
16-
redfish_facts:
16+
redfish_info:
1717
category: Manager
1818
command: GetManagerNicInventory
1919
baseuri: "{{ baseuri }}"

0 commit comments

Comments
 (0)