Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download libspdm code and its submodules twice #148

Open
lbbxsxlz opened this issue Sep 9, 2022 · 3 comments
Open

download libspdm code and its submodules twice #148

lbbxsxlz opened this issue Sep 9, 2022 · 3 comments
Assignees

Comments

@lbbxsxlz
Copy link
Contributor

lbbxsxlz commented Sep 9, 2022

When use "git submodule update --init --recursive" command to get the full repo, the libspdm code and its submodules will download twice.

The files in SPDM-Responder-Validator/libspdm directory are not necessary to build the spdm-emu executable files.

@jyao1
Copy link
Member

jyao1 commented Sep 19, 2022

@Wenxing-hou
Copy link
Contributor

9/19/2022 - The solution is to move https://github.com/DMTF/spdm-emu/tree/main/spdm_emu/spdm_device_validator_sample to https://github.com/DMTF/SPDM-Responder-Validator

Hi. When move spdm_emu/spdm_device_validator_sample to DMTF/SPDM-Responder-Validator, there are many code depend on spdm-emu.

${PROJECT_SOURCE_DIR}/spdm_emu/spdm_emu_common/spdm_emu.c
${PROJECT_SOURCE_DIR}/spdm_emu/spdm_emu_common/command.c
${PROJECT_SOURCE_DIR}/spdm_emu/spdm_emu_common/key.c
${PROJECT_SOURCE_DIR}/spdm_emu/spdm_emu_common/nv_storage.c
${PROJECT_SOURCE_DIR}/spdm_emu/spdm_emu_common/pcap.c
${PROJECT_SOURCE_DIR}/spdm_emu/spdm_emu_common/support.c

#include "library/spdm_requester_lib.h"
#include "library/spdm_transport_none_lib.h"
#include "library/spdm_transport_mctp_lib.h"
#include "library/spdm_transport_pcidoe_lib.h"
#include "library/mctp_requester_lib.h"
#include "library/pci_doe_requester_lib.h"

The independent DMTF/SPDM-Responder-Validator will not build successful without these code/lib support.

Wenxing-hou added a commit to Wenxing-hou/spdm-emu that referenced this issue Sep 27, 2022
Fix the issue: DMTF#148

Make the SPDM-Responder-Validator independent.
The SPDM-Responder-Validator will not be submodule after this PR.

Signed-off-by: Wenxing Hou <[email protected]>
Wenxing-hou added a commit to Wenxing-hou/spdm-emu that referenced this issue Sep 27, 2022
Fix the issue: DMTF#148

Signed-off-by: Wenxing Hou <[email protected]>
Wenxing-hou added a commit to Wenxing-hou/spdm-emu that referenced this issue Sep 27, 2022
Fix the issue: DMTF#148

Make the SPDM-Responder-Validator independent.
The SPDM-Responder-Validator will not be submodule after this PR.

Signed-off-by: Wenxing Hou <[email protected]>
Wenxing-hou added a commit to Wenxing-hou/spdm-emu that referenced this issue Sep 27, 2022
Fix the issue: DMTF#148

Signed-off-by: Wenxing Hou <[email protected]>
Wenxing-hou added a commit to Wenxing-hou/spdm-emu that referenced this issue Sep 27, 2022
Fix the issue: DMTF#148

Make the SPDM-Responder-Validator independent.
The SPDM-Responder-Validator will not be submodule after this PR.

Signed-off-by: Wenxing Hou <[email protected]>
Wenxing-hou added a commit to Wenxing-hou/spdm-emu that referenced this issue Sep 27, 2022
Fix the issue: DMTF#148

Signed-off-by: Wenxing Hou <[email protected]>
@jyao1
Copy link
Member

jyao1 commented Sep 28, 2022

Look at DMTF/SPDM-Responder-Validator#36.

It seems too many changes.

@steven-bellock , should we consider move below to libspdm ?

 #include "library/spdm_transport_mctp_lib.h" 
 #include "library/spdm_transport_pcidoe_lib.h" 
 #include "library/mctp_requester_lib.h" 
 #include "library/pci_doe_requester_lib.h" 

Still thinking what is the best way to organize those libraries. Let's discuss in the meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants