Skip to content

Inconsistent MaxSPDMmsgSize and DataTransferSize leads to SPDM-Responder-Validator test cases failure #458

@xiangfeima

Description

@xiangfeima

Using latest spdm-emu to run spdm_device_validator_sample , many test cases in SPDM-Responder-Validator are failed due to such reason.
For example, in test case 3.6, the CHUNK_CAP is not set for requester, however that MaxSPDMmsgSize is set to 0x28000 from PQC enabling commits while DataTransferSize remains as 0x1200.

The test case sets requester's capabilities at https://github.com/DMTF/SPDM-Responder-Validator/blob/a8b6c06f395a5e03cf965b03e57a57506a3b465a/library/spdm_responder_conformance_test_lib/spdm_responder_test_3_algorithms.c#L34-L67

The test case failure log:
(I added mctp trasport send/receive print by manual).

  test case 3.6 (spdm_test_case_algorithms_success_12) - setup enter
send-mctp (5 bytes)...
	 -> 0x00000000 : 01 00 00 C8 05 10 84 00 00 
send-mctp ... done
recv-mctp ...
	 -> 0x00000000 : 01 00 00 C0 05 10 04 00 00 00 03 00 10 00 11 00 12 
send-mctp (21 bytes)...
	 -> 0x00000000 : 01 00 00 C8 05 12 E1 00 00 00 00 00 00 C6 73 00 00 00 12 00 00 00 80 02 00 
send-mctp ... done
recv-mctp ...
	 -> 0x00000000 : 01 00 00 C0 05 12 7F 01 00 
  test case 3.6 (spdm_test_case_algorithms_success_12) - setup exit (0)
    test assertion 3.6.0 - NOT_TESTED case_setup_func fail
  test case 3.6 (spdm_test_case_algorithms_success_12) - teardown enter
  test case 3.6 (spdm_test_case_algorithms_success_12) - teardown exit

Looks 18e49ea was introduced for spdm_requester_emu and spdm_responder_emu, but missing for spdm_device_attester_sample and spdm_device_validator_sample?

Thank you!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions