Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use same base type for all components #10

Merged
merged 1 commit into from
Aug 28, 2024
Merged

fix: use same base type for all components #10

merged 1 commit into from
Aug 28, 2024

Conversation

dolfim-ibm
Copy link
Contributor

  1. Align the type of elements to a common base class
  2. Extend the _resolve_ref function for other types

@dolfim-ibm dolfim-ibm requested review from vagenas and ceberam August 28, 2024 08:46
@dolfim-ibm dolfim-ibm merged commit f450c8c into main Aug 28, 2024
9 checks passed
@dolfim-ibm dolfim-ibm deleted the resolve-figures branch August 28, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceberam ceberam ceberam approved these changes

@vagenas vagenas Awaiting requested review from vagenas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dolfim-ibm @ceberam