Skip to content

feat: added the new label comment_section in the groups#114

Merged
PeterStaar-IBM merged 2 commits intomainfrom
dev/add-comment-group
Dec 17, 2024
Merged

feat: added the new label comment_section in the groups#114
PeterStaar-IBM merged 2 commits intomainfrom
dev/add-comment-group

Conversation

@PeterStaar-IBM
Copy link
Member

To address comments and hidden text, we add a new group:

  1. Things like slide comments, Word review comments, etc. should go into the furniture root and be put inside a group with new GroupLabel.COMMENT_SECTION
  2. Optional: We can extend the type hierachy with a CommentItem, which additionally stores an author name and timestamp with the text.
  3. We must add filter argument for group labels on the export functions (additional to DocItemLabels)

@PeterStaar-IBM PeterStaar-IBM changed the title added the new label comment_section in the groups feat: added the new label comment_section in the groups Dec 17, 2024
@mergify
Copy link

mergify bot commented Dec 17, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

Signed-off-by: Peter Staar <[email protected]>
@PeterStaar-IBM PeterStaar-IBM merged commit 5101dd8 into main Dec 17, 2024
@PeterStaar-IBM PeterStaar-IBM deleted the dev/add-comment-group branch December 17, 2024 13:23
muhark added a commit to muhark/docling-core that referenced this pull request Mar 19, 2025
…ect#114)

* added the new label comment_section in the groups

Signed-off-by: Peter Staar <[email protected]>

* reformatted the code

Signed-off-by: Peter Staar <[email protected]>

---------

Signed-off-by: Peter Staar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants