Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added the new label comment_section in the groups #114

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

PeterStaar-IBM
Copy link
Contributor

To address comments and hidden text, we add a new group:

  1. Things like slide comments, Word review comments, etc. should go into the furniture root and be put inside a group with new GroupLabel.COMMENT_SECTION
  2. Optional: We can extend the type hierachy with a CommentItem, which additionally stores an author name and timestamp with the text.
  3. We must add filter argument for group labels on the export functions (additional to DocItemLabels)

@PeterStaar-IBM PeterStaar-IBM changed the title added the new label comment_section in the groups feat: added the new label comment_section in the groups Dec 17, 2024
Copy link

mergify bot commented Dec 17, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

Signed-off-by: Peter Staar <[email protected]>
@PeterStaar-IBM PeterStaar-IBM merged commit 5101dd8 into main Dec 17, 2024
8 checks passed
@PeterStaar-IBM PeterStaar-IBM deleted the dev/add-comment-group branch December 17, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants