You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was thinking about adding more methods to the sprite class with options that are currently missing, like image saturation, using the built in c# image processing or a graphics library and i found this.
public void Move(OsbEasing easing, double startTime, double endTime, CommandPosition startPosition, CommandPosition endPosition) => addCommand(new MoveCommand(easing, startTime, endTime, startPosition, endPosition)); public void Move(OsbEasing easing, double startTime, double endTime, CommandPosition startPosition, double endX, double endY) => Move(easing, startTime, endTime, startPosition, new CommandPosition(endX, endY)); public void Move(OsbEasing easing, double startTime, double endTime, double startX, double startY, double endX, double endY) => Move(easing, startTime, endTime, new CommandPosition(startX, startY), new CommandPosition(endX, endY)); public void Move(double startTime, double endTime, CommandPosition startPosition, CommandPosition endPosition) => Move(OsbEasing.None, startTime, endTime, startPosition, endPosition); public void Move(double startTime, double endTime, CommandPosition startPosition, double endX, double endY) => Move(OsbEasing.None, startTime, endTime, startPosition, endX, endY); public void Move(double startTime, double endTime, double startX, double startY, double endX, double endY) => Move(OsbEasing.None, startTime, endTime, startX, startY, endX, endY); public void Move(double time, CommandPosition position) => Move(OsbEasing.None, time, time, position, position); public void Move(double time, double x, double y) => Move(OsbEasing.None, time, time, x, y, x, y);
I believe there is a better way of handling multiple args and will happily make a pull request with a couple new functions along with the cleaned up code, but i just wanted to verify that this method isn't nescessary due to some internal logic.
if you'd be interested please tell me a bit about the code structure and the addCommand function and CommandPosition class.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
I was thinking about adding more methods to the sprite class with options that are currently missing, like image saturation, using the built in c# image processing or a graphics library and i found this.
public void Move(OsbEasing easing, double startTime, double endTime, CommandPosition startPosition, CommandPosition endPosition) => addCommand(new MoveCommand(easing, startTime, endTime, startPosition, endPosition)); public void Move(OsbEasing easing, double startTime, double endTime, CommandPosition startPosition, double endX, double endY) => Move(easing, startTime, endTime, startPosition, new CommandPosition(endX, endY)); public void Move(OsbEasing easing, double startTime, double endTime, double startX, double startY, double endX, double endY) => Move(easing, startTime, endTime, new CommandPosition(startX, startY), new CommandPosition(endX, endY)); public void Move(double startTime, double endTime, CommandPosition startPosition, CommandPosition endPosition) => Move(OsbEasing.None, startTime, endTime, startPosition, endPosition); public void Move(double startTime, double endTime, CommandPosition startPosition, double endX, double endY) => Move(OsbEasing.None, startTime, endTime, startPosition, endX, endY); public void Move(double startTime, double endTime, double startX, double startY, double endX, double endY) => Move(OsbEasing.None, startTime, endTime, startX, startY, endX, endY); public void Move(double time, CommandPosition position) => Move(OsbEasing.None, time, time, position, position); public void Move(double time, double x, double y) => Move(OsbEasing.None, time, time, x, y, x, y);I believe there is a better way of handling multiple args and will happily make a pull request with a couple new functions along with the cleaned up code, but i just wanted to verify that this method isn't nescessary due to some internal logic.
if you'd be interested please tell me a bit about the code structure and the addCommand function and CommandPosition class.
Beta Was this translation helpful? Give feedback.
All reactions