Skip to content

Commit 1db05ed

Browse files
committed
Revert "add temp fix since no proper fix exist at the moment"
This reverts commit 75ece9b.
1 parent 3033136 commit 1db05ed

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

lib/nfc/helpers/iso14443_4_layer.c

+1-5
Original file line numberDiff line numberDiff line change
@@ -66,13 +66,9 @@ bool iso14443_4_layer_decode_block(
6666

6767
bool ret = false;
6868

69-
// TODO: Fix properly! this is a very big kostyl na velosipede
70-
// (bit_buffer_copy_right are called to copy bigger buffer into smaller buffer causing crash on furi check) issue comes iso14443_4a_poller_send_block at line 109
71-
if(bit_buffer_get_size_bytes(output_data) < bit_buffer_get_size_bytes(output_data) - 1)
72-
return ret;
73-
7469
do {
7570
if(!bit_buffer_starts_with_byte(block_data, instance->pcb_prev)) break;
71+
// TODO: Fix crash
7672
bit_buffer_copy_right(output_data, block_data, 1);
7773
ret = true;
7874
} while(false);

lib/toolbox/bit_buffer.c

+1
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ void bit_buffer_copy_right(BitBuffer* buf, const BitBuffer* other, size_t start_
5858
furi_check(buf);
5959
furi_check(other);
6060
furi_check(bit_buffer_get_size_bytes(other) > start_index);
61+
// TODO: Fix crash
6162
furi_check(buf->capacity_bytes >= bit_buffer_get_size_bytes(other) - start_index);
6263

6364
memcpy(buf->data, other->data + start_index, bit_buffer_get_size_bytes(other) - start_index);

0 commit comments

Comments
 (0)