Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The back button hangs when using a subghz file #854

Open
Crsarmv7l opened this issue Jan 8, 2025 · 15 comments
Open

The back button hangs when using a subghz file #854

Crsarmv7l opened this issue Jan 8, 2025 · 15 comments
Labels
bug Something isn't working

Comments

@Crsarmv7l
Copy link

Crsarmv7l commented Jan 8, 2025 •
edited
Loading

Describe the bug.

Pressing the back button is not always responsive when using a Subghz file. This is not the case in any other app or when using any other function. It is worst with RAW's but still exists when using decoded protocols. It feels like a function is blocking.

Subghz menus are fine. It only appears after selecting a file to playback and not every time, but it is fairly frequent. It happens heavily with the Tesla Charge port files.

Reproduction

Favorites or subghz via a shortcut, select a file, Select Emulate (if not a raw), play it, press back. It does not go back often necessitating multiple fast presses, holding the back button, etc.

If you do not experience the issue, repeat the above a few times, going into a file, playing and trying to exit

Target

This did not happen with v73, but is present in the most recent 79 and the version previous to that (when I first updated past 73)

Logs

Video:
https://imgur.com/a/6EDsdLO

No response

Anything else?

Happy to provide a video if needed.
@Crsarmv7l Crsarmv7l added the bug Something isn't working label Jan 8, 2025
@Dmitry422
Copy link
Contributor

Dmitry422 commented Jan 15, 2025 •
edited
Loading

Not sure, but it can be not bug but a feature. Check with long press back button.

@Crsarmv7l
Copy link
Author

Crsarmv7l commented Jan 15, 2025 via email

@Dmitry422
Copy link
Contributor

I try replay your problem in dev.build - but I can't.
From shortcuts and from sub-ghz app - short press not exit (its normal) and long press exit every time when I long press key.

@Crsarmv7l
Copy link
Author

Crsarmv7l commented Jan 15, 2025 via email •
edited
Loading

@Dmitry422
Copy link
Contributor

I sow 2-3 short (not exit) and after 1 long press (exit). Its right ?
Looks like all work correct.

@Crsarmv7l
Copy link
Author

Crsarmv7l commented Jan 15, 2025 via email

@Crsarmv7l
Copy link
Author

Crsarmv7l commented Jan 15, 2025 via email •
edited
Loading

@Dmitry422
Copy link
Contributor

Dmitry422 commented Jan 15, 2025 •
edited
Loading

  1. Did you try dev builds ? Lets try exclude bug in release - try last dev build - 1081E
  2. Can you attach here you file - I will test it on my F0
  3. I don't know why exactly long press for exit was used, but I think for this exist some reasons.
  4. I don't try catch you, joke with you or something else - I just say that in some cases (some apps) long press exit button its normal and your first video looks normal.

Finally we can make a tests - you try dev build and me try you file. And after we can find right answer for this bug.

@Crsarmv7l
Copy link
Author

  1. Did you try dev builds ? Lets try exclude bug in release - try last dev build - 1081E
  2. Can you attach here you file - I will test it on my F0
  3. I don't know why exactly long press for exit was used, but I think for this exist some reasons.
  4. I don't try catch you, joke with you or something else - I just say that in some cases (some apps) long press exit button its normal and your first video looks normal.

Finally we can make a tests - you try dev build and me try you file. And after we can find right answer for this bug.

  1. I have not, but I will. Might take a few days
  2. File attached. Rename txt to .sub. As I said multiple times; it does not happen every time. But it does happen pretty frequently.
  3. I highly doubt MMX changed the behavior of the button between 73 and current. But anything is possible. When the button is recognized a short press is enough to go back.

Tesla_Charge_Port_315MHz_AM270.txt

@Dmitry422
Copy link
Contributor

Hello!
I test your file about 3-4 times with 10-15 repeats every tests - no one problem, exit every time on short press.

@Crsarmv7l
Copy link
Author

Crsarmv7l commented Jan 18, 2025 •
edited
Loading

Hello! I test your file about 3-4 times with 10-15 repeats every tests - no one problem, exit every time on short press.

As I have said MULTIPLE TIMES it is intermittent, also why I provided a video. Just this morning i tried it 20 times without triggering the bug.

I am not going to go through this any more with you. You started off by telling me "long press for back is a feature" even when I told you it isn't and there was no changelog stating that change was made. Now you said "well I tried it 3 times so there is no issue" despite two literal videos.

While I find flipper's source too abstracted, I have contributed numerous features and fixes to both Radiolib, Rfcat and others and I can write C and C++ well enough to do what I want (if inefficiently). I am not an unreliable reporting source.

This issue will stay open because it is a bug, with proof, both on the decoded as you observed with 2-3 short presses doing nothing, and on the raw with multiple long presses doing nothing.

@Dmitry422
Copy link
Contributor

Dmitry422 commented Jan 18, 2025 •
edited
Loading

Im not often use sub-ghz - my experience not so big. In some cases like barriers (locks) sub-ghz record exit only with long press, in another cases like your file exit by short press. So different cases - different presses.

I think in your cases may be hardware problem with key pad. But if you sure that isn't hardware - no problem, will be wait the same reports from another users.

@Crsarmv7l
Copy link
Author

Crsarmv7l commented Jan 18, 2025 via email •
edited
Loading

@Crsarmv7l
Copy link
Author

Additionally if this were a hardware issue, decoded subs that "stick" would exhibit the same "long press doesn't exit" they don't. A long press always exits a decoded sub.

Raws hang for forever when they hang

@Dmitry422
Copy link
Contributor

"No. Long press is not a thing with the back button in subghz." - my barrier subghz record exit only with long press. In subghz source we can find string if(event->key == InputKeyBack && event->type == InputTypeLong).
So in some cases long press used for exit instead of short press. So your case is an unusual case.

And did you try last dev build ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Crsarmv7l @Dmitry422