BUG: Getting kicked/disconnected while in Brick-By-Brick building mode causes the currently selected model to be wiped

[I-Am-Dench]

Make sure you've done the following:

• I have checked that this issue has not already been reported.

• I have validated that this issue is not a syntax error of either MySQL or SQLite.

• I have pulled the latest version of the main branch of DarkflameServer and have confirmed that the issue exists there.

DarkflameServer Version

aaf446f

Issue Description

If the player is disconnected from the server (sent to login screen or upon crashing), the model that was currently being edited in Brick-By-Brick building is wiped.

Looking through the code, it seems like the regardless of how the player leave the Brick-By-Brick building state, the server attempts to save the model data, but since disconnecting doesn't send any model data, it saves the model as empty, effectively clearing everything.

This only effects the currently edited model. Models already placed down and/or built on properties remain.

While there is no Issues regarding the following, it could also be considered a fix for this Issue: Player is AFK kicked while in Brick-By-Brick building -- I have not found any evidence from live for player's not getting AFK kicked while in Brick-By-Brick building.

Either disabling the AFK timer while the player is building or checking the way in which the player disconnected from the property and saving accordingly would seem like the solutions. Having both seems optimal.

Reproduction Steps

1. Enter any personally-owned, claimed property and equip the Thinking Hat to enter edit mode
2. Place down any model
3. Enter Brick Build mode and place any number of bricks, then click Place Models to save the current model
4. Enter Brick Build mode again to start building a second model and place any number of bricks, then click Place Models to save the current model
5. Enter Brick Build mode and then edit either of the previous 2 custom models
6. Forcefully disconnect from the server by either force closing the game or waiting to be AFK kicked
7. Login and reenter the property
8. Observe that the last selected model was wiped

Expected Behavior

Again, I don't have evidence from live, but I would assume that models should just roll back to the previously saved version, or players shouldn't be kicked while building.

Environment

Ubuntu

[aronwk-aaron]

yes, BBB is very buggy and incomplete.
It's slowly being fixed, but in scenarios like you described above, yes you will lose the model or lose progress on the model

[EmosewaMC]

Thank you for the report

as a note: the auto save feature is only done every 5 minutes in the vanilla client, so in this case you wouldn't see it be saved anyways. The big problem is brick building is just not a priority, complex, and for almost 10 years it was thought that you cannot have brick built items in the inventory without them kicking the player from the server.