Skip to content

Commit 03bbc02

Browse files
committed
Merge branch 'development' of https://github.com/Dash-Industry-Forum/dash.js into feature/certurl
2 parents 2a84393 + f2372bf commit 03bbc02

File tree

67 files changed

+3390
-1100
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

67 files changed

+3390
-1100
lines changed

CONTRIBUTING.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
# How to contribute #
2+
3+
> **Note:** For the most up-to-date contribution guidelines, please refer to our official documentation at [https://dashif.org/dash.js/pages/developers/how-to-contribute.html](https://dashif.org/dash.js/pages/developers/how-to-contribute.html)
4+
25
As an open source project, operating under a [meritocratic governance model](https://github.com/Dash-Industry-Forum/dash.js/wiki/governance-model), we welcome contributions of any kind. Naturally this includes software contributions, but we also welcome help on documentation, testing, project coordination, marketing, [release preparation](https://github.com/Dash-Industry-Forum/dash.js/wiki/Release-Management) and more.
36

47
For any kind of contribution your first port of call should be to join our [mailing list]( https://groups.google.com/d/forum/dashjs). We welcome all contributions to the mailing list (including asking questions which demonstrate our documentation needs to be improved).
@@ -38,12 +41,12 @@ If you find a low priority issues is affecting your use case then the only way t
3841
## Process for contributing code
3942

4043
1. Before starting work on a new feature, enhancement or fix, ask the group if anyone else is already working on the same task. This will avoid duplication of effort.
41-
1. Read and understand the wiki sections on [Developer Getting Started Guide](https://github.com/Dash-Industry-Forum/dash.js/wiki/Developer-Getting-Started-Guide) and [JSLint compliance](https://github.com/Dash-Industry-Forum/dash.js/wiki/JSLint-Compliance).
44+
1. Read and understand the developer documentation at [https://dashif.org/dash.js/pages/developers/](https://dashif.org/dash.js/pages/developers/), including information about code quality and ESLint compliance.
4245
1. Read and understand the project's [Branching Strategy](http://nvie.com/posts/a-successful-git-branching-model/).
4346
1. Fork the repository and setup a new branch to work in.
4447
1. In each of your files, include the required BSD-3 header available [here](https://dashif.org/docs/dash.js.license-header.May2013.txt). Be sure to replace the placeholder text "YOUR_COMPANY_NAME_HERE" with the name of your company before adding it to the header.
4548
1. Add or modify unit tests for any new or modified functionality in your patch.
46-
1. Run `grunt` before you commit so that you may catch test failures, lint issues, or syntax errors. Pull requests that do not compile or pass linter checks or pass all unit tests will not be accepted.
49+
1. Run `npm run build` before you commit so that you may catch test failures, lint issues, or syntax errors. Pull requests that do not compile or pass linter checks or pass all unit tests will not be accepted.
4750
1. If you are submitting code as an individual or on behalf of a company who is _not a member_ of the DASH [Industry Forum](http://dashif.org/members), then download, sign, scan and email back to the email list the [Feedback Agreement](https://dashif.org/docs/DASH-IF-Feedback-Agreement-3-7-2014.pdf). Your code will not be reviewed and accepted by the Admins until this has been received. DASH IF members do not need to take this step, as the Forum's By-Laws already cover your submission to this open source project.
4851
1. Issue a Pull Request.
4952
1. The Admins will review your code and may optionally request conformance, functional or other changes. Work with them to resolve any issues.

index.d.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1754,7 +1754,8 @@ export class MediaPlayerSettingClass {
17541754
defaultTimingSource?: {
17551755
scheme?: string,
17561756
value?: string
1757-
}
1757+
},
1758+
artificialTimeOffsetToApply?: number
17581759
},
17591760
scheduling?: {
17601761
defaultTimeout?: number,

package-lock.json

Lines changed: 4 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

samples/dash-if-reference-player/app/main.js

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -768,6 +768,16 @@ app.controller('DashController', ['$scope', '$window', 'sources', 'contributors'
768768
});
769769
};
770770

771+
$scope.updateUtcTimeSyncOffset = function () {
772+
$scope.player.updateSettings({
773+
streaming: {
774+
utcSynchronization: {
775+
artificialTimeOffsetToApply: parseInt($scope.utcTimeSyncOffset)
776+
}
777+
}
778+
});
779+
};
780+
771781
$scope.updateInitialBitrateVideo = function () {
772782
$scope.player.updateSettings({
773783
streaming: {
@@ -2509,7 +2519,7 @@ app.controller('DashController', ['$scope', '$window', 'sources', 'contributors'
25092519

25102520
function setAdditionalAbrOptions() {
25112521
var currentConfig = $scope.player.getSettings();
2512-
$scope.fastSwitchSelected = currentConfig.streaming.buffer.fastSwitchEnabled;
2522+
$scope.fastSwitchSelected = currentConfig.streaming.buffer.fastSwitchEnabled !== null ? currentConfig.streaming.buffer.fastSwitchEnabled : true;
25132523
$scope.videoAutoSwitchSelected = currentConfig.streaming.abr.autoSwitchBitrate.video;
25142524
}
25152525

@@ -2532,6 +2542,11 @@ app.controller('DashController', ['$scope', '$window', 'sources', 'contributors'
25322542
$scope.useSuggestedPresentationDelay = currentConfig.streaming.delay.useSuggestedPresentationDelay;
25332543
}
25342544

2545+
function setUtcTimeSyncOptions() {
2546+
var currentConfig = $scope.player.getSettings();;
2547+
$scope.utcTimeSyncOffset = currentConfig.streaming.utcSynchronization.artificialTimeOffsetToApply;
2548+
}
2549+
25352550
function setStallThresholdOptions() {
25362551
var currentConfig = $scope.player.getSettings();
25372552
$scope.stallThreshold = currentConfig.streaming.buffer.stallThreshold;
@@ -2698,6 +2713,7 @@ app.controller('DashController', ['$scope', '$window', 'sources', 'contributors'
26982713
setDrmOptions();
26992714
setTextOptions();
27002715
setLiveDelayOptions();
2716+
setUtcTimeSyncOptions();
27012717
setStallThresholdOptions()
27022718
setInitialSettings();
27032719
setTrackSwitchModeSettings();

0 commit comments

Comments
 (0)