Skip to content

Commit 8a44f97

Browse files
add new Petab Select version to arInit, deprecate old version
1 parent b795cb4 commit 8a44f97

File tree

2 files changed

+13
-10
lines changed

2 files changed

+13
-10
lines changed

arFramework3/Deprecated/arPEtabSelect.m renamed to arFramework3/Deprecated/arPEtabSelect_old.m

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
% arPEtabSelect(venvActPath, yaml, limit, estimRoutine)
1+
% arPEtabSelect_old(venvActPath, yaml, limit, estimRoutine)
22
%
33
% Run model selection using PEtab-select (https://github.com/PEtab-dev/petab_select)
4-
% Requires installation of the petab_select Python3 package. arPEtabSelect
4+
% Requires installation of the petab_select Python3 package. arPEtabSelect_old
55
% uses the command line interface (CLI).
66
%
77
% [venvActPath] Path to a python virtual environment (venv) activation
@@ -24,7 +24,7 @@
2424
% initial guess for all estimated parameters and additionally perform
2525
% multi-start optimization with 20 runs:
2626
%
27-
% arPEtabSelect('~/d2d_python_venv/bin/activate', ...
27+
% arPEtabSelect_old('~/d2d_python_venv/bin/activate', ...
2828
% '~/test_cases/0001/petab_select_problem',...
2929
% 3,
3030
% 'ar.p(ar.qFit == 1) = 0.3; arFit; arFitLHS(20)')
@@ -33,7 +33,7 @@
3333
% (Leave empty initialModel & iterationCtr. Those are internal arguments
3434
% to allow for recursive function call)
3535

36-
function arPEtabSelect(venvActPath, yaml, limit, estimRoutine, initialModel, iterationCtr)
36+
function arPEtabSelect_old(venvActPath, yaml, limit, estimRoutine, initialModel, iterationCtr)
3737
if ~exist('iterationCtr') || isempty(iterationCtr)
3838
iterationCtr = 1;
3939
end
@@ -85,7 +85,7 @@ function arPEtabSelect(venvActPath, yaml, limit, estimRoutine, initialModel, ite
8585
end
8686

8787
%% Call PEtab-select to generate candidate models
88-
fprintf('arPEtabSelect: Generating candidate models...\n')
88+
fprintf('arPEtabSelect_old: Generating candidate models...\n')
8989
syscom = [initstr,...
9090
'petab_select candidates ', ...
9191
' -y ', yaml, ...
@@ -112,11 +112,11 @@ function arPEtabSelect(venvActPath, yaml, limit, estimRoutine, initialModel, ite
112112
nModels = size(CandidateModels,2);
113113

114114
if nModels < 1
115-
fprintf('arPEtabSelect: Finished after iteration %i - no (more) candidate models found.\n', iterationCtr-1)
115+
fprintf('arPEtabSelect_old: Finished after iteration %i - no (more) candidate models found.\n', iterationCtr-1)
116116
terminateFlag = 1;
117117
end
118118
if terminateFlag == 0
119-
fprintf('arPEtabSelect: Calibrating candidate models...\n')
119+
fprintf('arPEtabSelect_old: Calibrating candidate models...\n')
120120

121121
for jModel = 1:nModels
122122
% Load & compile
@@ -214,7 +214,7 @@ function arPEtabSelect(venvActPath, yaml, limit, estimRoutine, initialModel, ite
214214
currentItCrit = currentIt.criteria.(SelectionProblem.criterion);
215215

216216
if round(currentItCrit,4) > round(prevItCrit,4)
217-
fprintf('arPEtabSelect: Finished after iteration %i - criterion worse than in iteration %i.\n', iterationCtr, iterationCtr-1)
217+
fprintf('arPEtabSelect_old: Finished after iteration %i - criterion worse than in iteration %i.\n', iterationCtr, iterationCtr-1)
218218
terminateFlag = 1;
219219
end
220220
end
@@ -238,6 +238,6 @@ function arPEtabSelect(venvActPath, yaml, limit, estimRoutine, initialModel, ite
238238
end
239239

240240
%% Next iteration
241-
fprintf('arPEtabSelect: Iteration %i complete. Continuing with next iteration\n',iterationCtr)
242-
arPEtabSelect(venvActPath, yaml, limit, estimRoutine, CalibYamlOut ,iterationCtr+1)
241+
fprintf('arPEtabSelect_old: Iteration %i complete. Continuing with next iteration\n',iterationCtr)
242+
arPEtabSelect_old(venvActPath, yaml, limit, estimRoutine, CalibYamlOut ,iterationCtr+1)
243243
end

arFramework3/Subfunctions/arCheck.m

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,9 @@
9595
if(exist('model_template_HillFunctions.def','file') == 0)
9696
addpath([ar_path '/ProjectTemplate']);
9797
end
98+
if(exist('arPetsInitModule','file') == 0)
99+
addpath([ar_path '/PEtabSelect']);
100+
end
98101

99102

100103
warning('off','MATLAB:rmpath:DirNotFound')

0 commit comments

Comments
 (0)