fix: add dropdownicon to muiselect default props (#356) #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request sets the default icon for MuiSelect by adding a DropDownIcon to the theme configuration, and removes the redundant explicit icon assignment in the Select component.
- Adds an import and defaultProps for DropDownIcon in the theme file.
- Removes the manual IconComponent assignment from the Select component.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/theme/common/components.ts | Adds defaultProps with DropDownIcon to MuiSelect. |
| src/components/common/Form/components/Select/select.tsx | Removes explicit IconComponent prop from MSelect. |
NoopDog
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests pass with icon in Select default props in theme!
Closes #356.