Skip to content

Commit be4cc64

Browse files
authored
Follow-up to #572 (#578)
* Be careful with the tags you use * No need to log standard idempotent 5m checks at INFO
1 parent 3891549 commit be4cc64

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

controllers/disruption_controller.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ func (r *DisruptionReconciler) Reconcile(ctx context.Context, req ctrl.Request)
241241
requeueDelay := *r.ExpiredDisruptionGCDelay
242242

243243
r.recordEventOnDisruption(instance, chaosv1beta1.EventDisruptionDurationOver, requeueDelay.String())
244-
r.log.Infow("requeuing disruption to check for its expiration", "requeueDelay", requeueDelay.String())
244+
r.log.Debugw("requeuing disruption to check for its expiration", "requeueDelay", requeueDelay.String())
245245

246246
return ctrl.Result{
247247
Requeue: true,
@@ -309,7 +309,7 @@ func (r *DisruptionReconciler) Reconcile(ctx context.Context, req ctrl.Request)
309309
// - an instance with at least one chaos pod as "ready" is considered as "partially injected"
310310
// - an instance with no ready chaos pods is considered as "not injected"
311311
func (r *DisruptionReconciler) updateInjectionStatus(instance *chaosv1beta1.Disruption) (bool, error) {
312-
r.log.Infow("checking if injection status needs to be updated", "injectionStatus", instance.Status.InjectionStatus)
312+
r.log.Debugw("checking if injection status needs to be updated", "injectionStatus", instance.Status.InjectionStatus)
313313

314314
status := chaostypes.DisruptionInjectionStatusNotInjected
315315
readyPodsCount := 0

injector/network_disruption.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -450,7 +450,7 @@ func (i *networkDisruptionInjector) addServiceFilters(serviceName string, filter
450450
for _, filter := range filters {
451451
filter.priority = i.getNewPriority()
452452

453-
i.config.Log.Infow("found service endpoint", "endpoint", filter.service.String(), "service", serviceName)
453+
i.config.Log.Infow("found service endpoint", "resolvedEndpoint", filter.service.String(), "resolvedService", serviceName)
454454

455455
err := i.config.TrafficController.AddFilter(interfaces, "1:0", filter.priority, 0, nil, filter.service.ip, 0, filter.service.port, filter.service.protocol, flowid)
456456
if err != nil {
@@ -769,7 +769,7 @@ func (i *networkDisruptionInjector) watchServiceChanges(watcher serviceWatcher,
769769
if !ok { // channel is closed
770770
watcher.kubernetesServiceWatcher = nil
771771
} else {
772-
i.config.Log.Infow(fmt.Sprintf("changes in service %s/%s", watcher.watchedServiceSpec.Name, watcher.watchedServiceSpec.Namespace), "eventType", event.Type)
772+
i.config.Log.Debugw(fmt.Sprintf("changes in service %s/%s", watcher.watchedServiceSpec.Name, watcher.watchedServiceSpec.Namespace), "eventType", event.Type)
773773

774774
if err := i.handleKubernetesServiceChanges(event, &watcher, interfaces, flowid); err != nil {
775775
i.config.Log.Errorf("couldn't apply changes to tc filters: %w... Rebuilding watcher", err)
@@ -786,7 +786,7 @@ func (i *networkDisruptionInjector) watchServiceChanges(watcher serviceWatcher,
786786
if !ok { // channel is closed
787787
watcher.kubernetesPodEndpointsWatcher = nil
788788
} else {
789-
i.config.Log.Infow(fmt.Sprintf("changes in pods of service %s/%s", watcher.watchedServiceSpec.Name, watcher.watchedServiceSpec.Namespace), "eventType", event.Type)
789+
i.config.Log.Debugw(fmt.Sprintf("changes in pods of service %s/%s", watcher.watchedServiceSpec.Name, watcher.watchedServiceSpec.Namespace), "eventType", event.Type)
790790

791791
if err := i.handleKubernetesPodsChanges(event, &watcher, interfaces, flowid); err != nil {
792792
i.config.Log.Errorf("couldn't apply changes to tc filters: %w... Rebuilding watcher", err)

0 commit comments

Comments
 (0)