[BUG] Build problem with Ginkgo

[ben]

Version of orchestrion

Orchestrion v1.5.0

Describe what happened:
Following the simple bootstrap steps (install then orchestrion pin) on a project that also includes Ginkgo v2, the build fails with this output:

❯ orchestrion go build .
❯ orchestrion go build . 
go: downloading github.com/onsi/ginkgo/v2 v2.22.1
# github.com/onsi/ginkgo/v2/internal/parallel_support
/Users/bstraub/go/pkg/mod/github.com/onsi/ginkgo/v2@v2.22.1/internal/parallel_support/http_client.go:25: undefined: __orchestrion_client.serverHost
/Users/bstraub/go/pkg/mod/github.com/onsi/ginkgo/v2@v2.22.1/internal/parallel_support/http_client.go:46: undefined: __orchestrion_client.serverHost
/Users/bstraub/go/pkg/mod/github.com/onsi/ginkgo/v2@v2.22.1/internal/parallel_support/http_client.go:59: undefined: __orchestrion_client.serverHost
/Users/bstraub/go/pkg/mod/github.com/onsi/ginkgo/v2@v2.22.1/internal/parallel_support/http_client.go:163: undefined: __orchestrion_client.serverHost
exit status 2
exit status 1

Steps to reproduce the issue:

Here's a repo that fails to build on my machine with the above error message: https://github.com/ben/ginkgo-orchestrion-test

Additional environment details (Version of Go, Operating System, etc.):

❯ orchestrion version
orchestrion v1.5.0

❯ go version
go version go1.24.3 darwin/arm64

❯ env | grep '^GO'
GOBIN=/Users/bstraub/.local/share/mise/installs/go/1.24.3/bin
GOROOT=/Users/bstraub/.local/share/mise/installs/go/1.24.3

[eliottness]

👋 Thanks for reporting this issue,

Running the following script gives me the diff of what as changed in ginkgo:

❯ orchestrion go build -a -work .
WORK=/tmp/go-build595129029
[...]
$ orchestrion diff --filter onsi/ginkgo /tmp/go-build595129029
--- /home/eliott/go/pkg/mod/github.com/onsi/ginkgo/v2@v2.22.1/internal/parallel_support/http_client.go
+++ b081/orchestrion/src/github.com/onsi/ginkgo/v2/internal/parallel_support/http_client.go
@@ -9,8 +10,11 @@
 	"time"
 
 	"github.com/onsi/ginkgo/v2/types"
+//line <generated>:1
+	__orchestrion_client "github.com/DataDog/dd-trace-go/contrib/net/http/v2/client"
 )
 
+//line /home/eliott/go/pkg/mod/github.com/onsi/ginkgo/v2@v2.22.1/internal/parallel_support/http_client.go:14
 type httpClient struct {
 	serverHost string
 }
@@ -22,7 +26,7 @@
 }
 
 func (client *httpClient) Connect() bool {
-	resp, err := http.Get(client.serverHost + "/up")
+	resp, err := http.Get(__orchestrion_client.serverHost + "/up")
 	if err != nil {
 		return false
 	}
@@ -43,7 +47,7 @@
 		}
 		body = bytes.NewBuffer(encoded)
 	}
-	resp, err := http.Post(client.serverHost+path, "application/json", body)
+	resp, err := http.Post(__orchestrion_client.serverHost+path, "application/json", body)
 	if err != nil {
 		return err
 	}
@@ -56,7 +60,7 @@
 
 func (client *httpClient) poll(path string, data interface{}) error {
 	for {
-		resp, err := http.Get(client.serverHost + path)
+		resp, err := http.Get(__orchestrion_client.serverHost + path)
 		if err != nil {
 			return err
 		}
@@ -160,7 +164,7 @@
 }
 
 func (client *httpClient) Write(p []byte) (int, error) {
-	resp, err := http.Post(client.serverHost+"/emit-output", "text/plain;charset=UTF-8 ", bytes.NewReader(p))
+	resp, err := http.Post(__orchestrion_client.serverHost+"/emit-output", "text/plain;charset=UTF-8 ", bytes.NewReader(p))
 	resp.Body.Close()
 	if resp.StatusCode != http.StatusOK {
 		return 0, fmt.Errorf("failed to emit output")

It seems the net/http client aspect is supposed to apply here but it cannot because there is no context to add to those functions. In-and-of-itself this should be harmless but it seems that the import identifier rename function is triggering on a wrong identifier. Do you have more clues @RomainMuller ?

[eliottness]

In the mean time @ben you can disable the net/http integration following this documentation