Store sampling context as a map element. This ensures propagation.

See node/lib/internal/async_context_frame.js AsyncContextFrame constructor.

Author: szegedi

bindings/profilers/wall.cc

@@ -1035,13 +1035,13 @@ void WallProfiler::SetContext(Isolate* isolate, Local<Value> value) {
 
   auto cped = isolate->GetContinuationPreservedEmbedderData();
   // No Node AsyncContextFrame in this continuation yet
-  if (!cped->IsObject()) return;
+  if (!cped->IsMap()) return;
 
   auto v8Ctx = isolate->GetCurrentContext();
   // This should always be called from a V8 context, but check just in case.
   if (v8Ctx.IsEmpty()) return;
 
-  auto cpedObj = cped.As<Object>();
+  auto cpedObj = cped.As<Map>();
   auto localSymbol = cpedSymbol_.Get(isolate);
   auto maybeProfData = cpedObj->Get(v8Ctx, localSymbol);
   if (maybeProfData.IsEmpty()) return;
@@ -1057,7 +1057,7 @@ void WallProfiler::SetContext(Isolate* isolate, Local<Value> value) {
     auto maybeSetResult = cpedObj->Set(v8Ctx, localSymbol, external);
     std::atomic_signal_fence(std::memory_order_release);
     setInProgress.store(false, std::memory_order_relaxed);
-    if (maybeSetResult.IsNothing()) {
+    if (maybeSetResult.IsEmpty()) {
       delete contextPtr;
       return;
     }
@@ -1107,12 +1107,12 @@ ContextPtr WallProfiler::GetContextPtr(Isolate* isolate) {
 #define RETURN_EMPTY_IF(x) if (x) return std::shared_ptr<Global<Value>>()
 
   auto cped = isolate->GetContinuationPreservedEmbedderData();
-  RETURN_EMPTY_IF(!cped->IsObject());
+  RETURN_EMPTY_IF(!cped->IsMap());
 
   auto v8Ctx = isolate->GetEnteredOrMicrotaskContext();
   RETURN_EMPTY_IF(v8Ctx.IsEmpty());
 
-  auto cpedObj = cped.As<Object>();
+  auto cpedObj = cped.As<Map>();
   auto localSymbol = cpedSymbol_.Get(isolate);
   auto maybeProfData = cpedObj->Get(v8Ctx, localSymbol);
   RETURN_EMPTY_IF(maybeProfData.IsEmpty());