Use AsyncHooksGetExecutionAsyncId(Context) API on Node 24 (#210)

szegedi · web-flow · commit bfa2637a329d · 2025-05-15T10:36:21.000+02:00
diff --git a/bindings/profilers/wall.cc b/bindings/profilers/wall.cc
@@ -1021,8 +1021,13 @@ NAN_METHOD(WallProfiler::Dispose) {
 }
 
 double GetAsyncIdNoGC(v8::Isolate* isolate) {
-  return isolate->InContext() ? node::AsyncHooksGetExecutionAsyncId(isolate)
-                              : -1;
+#if NODE_MAJOR_VERSION >= 24
+  HandleScope scope(isolate);
+  auto context = isolate->GetEnteredOrMicrotaskContext();
+  return context.IsEmpty() ? -1 : node::AsyncHooksGetExecutionAsyncId(context);
+#else
+  return node::AsyncHooksGetExecutionAsyncId(isolate);
+#endif
 }
 
 double WallProfiler::GetAsyncId(v8::Isolate* isolate) {

Original file line number	Diff line number	Diff line change
`@@ -1021,8 +1021,13 @@ NAN_METHOD(WallProfiler::Dispose) {`
`1021`	`1021`	`}`
`1022`	`1022`
`1023`	`1023`	`double GetAsyncIdNoGC(v8::Isolate* isolate) {`
`1024`		`- return isolate->InContext() ? node::AsyncHooksGetExecutionAsyncId(isolate)`
`1025`		`- : -1;`
	`1024`	`+#if NODE_MAJOR_VERSION >= 24`
	`1025`	`+ HandleScope scope(isolate);`
	`1026`	`+ auto context = isolate->GetEnteredOrMicrotaskContext();`
	`1027`	`+ return context.IsEmpty() ? -1 : node::AsyncHooksGetExecutionAsyncId(context);`
	`1028`	`+#else`
	`1029`	`+ return node::AsyncHooksGetExecutionAsyncId(isolate);`
	`1030`	`+#endif`
`1026`	`1031`	`}`
`1027`	`1032`
`1028`	`1033`	`double WallProfiler::GetAsyncId(v8::Isolate* isolate) {`