removed a bunch of debug traces

Author: DavisDevelopment

src/pman/bg/MediaTools.hx

@@ -26,23 +26,24 @@ class MediaTools {
 }
 
 class MediaRowTools {
-    /**
-      * convert a MediaRow to a Media object
-      */
-    //public static inline function toMedia(row: MediaRow):Media {
-        //return new Media(MediaSourceTools.toMediaSource( row.uri ), row);
-    //}
+
 }
 
 @:expose('MediaSourceTools')
 class MediaSourceTools {
+    /**
+      convert given MediaSource value to a URI string
+     **/
     public static function toUri(src: MediaSource):String {
         return (switch ( src ) {
             case MSLocalPath( path ): ('file://' + path.toString());
             case MSUrl( url ): url;
         });
     }
 
+    /**
+      convert given MediaSource value to a Media instance
+     **/
     public static inline function toMedia(src: MediaSource):Media {
         return new Media( src );
     }
@@ -54,8 +55,8 @@ class MediaSourceTools {
 @:expose('UriTools2')
 class UriTools {
     /**
-      * convert a URI String into a Media instance
-      */
+      convert given Uri to Media instance
+     **/
     public static function toMedia(uri: String):Null<Media> {
         uri = uri.toUri();
         if (uri != null) {
@@ -105,7 +106,6 @@ class UriTools {
                         var uri_path:String = uri.toFilePath().toString();
                         handleFsPath( uri_path );
                         throw PManError.PMEFileSystemError(EMalformedPathError(uri_path));
-                        //throw 'Error: Malformed FileSystem path "${uri.toFilePath()}"';
 
                     default:
                         return MSUrl( uri );

src/pman/bg/URITools.hx

@@ -128,7 +128,6 @@ class URITools {
         var pre:PRegEx = PRegEx.build(function(re: PRegEx) {
             return re.anyOf('!*\'();:@&=+$,/?#[]', false, true).or().whitespace();
         }).withOptions('g');
-        trace(pre.toString());
         var re:RegEx = pre.toRegEx();
         return re.map(text, function(re) {
             return ('%' + re.matched(0).charCodeAt(0).hex(2));

src/pman/media/MediaTools.hx

@@ -40,14 +40,17 @@ using pman.bg.MediaTools;
 @:expose('MediaTools')
 class MediaTools {
     /**
-      * probe the given Directory for all openable files
-      */
+      probe the given Directory for all openable files
+     **/
     public static function getAllOpenableFiles(dir:Directory, done:Array<File>->Void):Void {
         var probe = new OpenableFileProbe();
         probe.setSources([dir]);
         probe.run( done );
     }
 
+    /**
+      probe many directories for all contained files that PMan can open
+     **/
     public static function igetAllOpenableFiles(idir:Iterable<Directory>, done:Array<File>->Void):Void {
         var coll = new Array();
         function collect(d:Directory, next:Void->Void) {
@@ -66,34 +69,33 @@ class MediaTools {
     }
 
     /**
-      * convert the given file list into a track list
-      */
+      convert the given list of File instances into a list of Track instances
+     **/
     public static inline function convertToTracks(files : Array<File>):Array<Track> {
         return (new FileListConverter().convert( files ).toArray());
     }
 
     /**
-      * initialize a list of Tracks all at once
-      */
+      initialize a list of Track instances all at once
+     **/
     public static function initAll(tracks:Array<Track>, done:Void->Void):Void {
         var initter = new TrackListInitializer();
         initter.initAll(tracks, function(count : Int) {
             done();
         });
     }
 
-    /**
-      * load data for a list of Tracks
-      */
+    /*
     @:deprecated
     public static function loadDataForAll(tracks:Array<Track>, ?done:Cb<TLDLResult>):Void {
         var loader = new TrackListDataLoader();
         loader.load(tracks, done);
     }
+    */
 
-	/**
-	  * get underlying media object from the given MediaObject
-	  */
+    /**
+      get underlying media object from the given MediaObject
+     **/
 	@:access( gryffin.display.Video )
 	@:access( gryffin.audio.Audio )
 	public static function getUnderlyingMediaObject(mo : MediaObject):NativeMediaObject {
@@ -108,14 +110,14 @@ class MediaTools {
         }
 	}
 
-	/**
-	  * load the MediaMetadata attached to the given MediaSource
-	  */
+    /**
+	  load the MediaMetadata attached to the given MediaSource
+     **/
 	public static function getMediaMetadata(src:MediaSource):Promise<Null<MediaMetadata>> {
-	    return Promise.create({
+	    return new Promise(function(yes, no) {
 	        switch ( src ) {
                 case MSLocalPath( path ):
-                    @forward new LoadMediaMetadata( path ).getMetadata();
+                    yes(cast new LoadMediaMetadata( path ).getMetadata());
 
                 default:
                     throw 'Error: Media metadata can only be loaded for media items located on the local filesystem';
@@ -129,6 +131,9 @@ class MediaTools {
 	public static inline function stripSlashSlash(s : String):String return s.withoutLeadingSlashes();
 }
 
+/**
+  mixins for Uri strings
+ **/
 class UriTools {
     //
     public static function toMediaProvider(uri: String):MediaProvider {

src/pman/ui/PlaylistView.hx

@@ -140,10 +140,6 @@ class PlaylistView extends Pane {
 		player.session.trackChanged.off( on_track_change );
 		//player.session.playlist.changeEvent.off( on_playlist_change );
 		unbindQueue( player.session.playlist );
-
-        // output to console so I can check if listeners are being properly unbound
-		echo( player.session.trackChanged );
-		echo( player.session.playlist.changeEvent );
 	}
 
 	public function bindQueue(q: Playlist):Void {