Skip to content

Cannot login with just created account #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timfel opened this issue Feb 8, 2022 · 2 comments
Open

Cannot login with just created account #2

timfel opened this issue Feb 8, 2022 · 2 comments

Comments

@timfel
Copy link

timfel commented Feb 8, 2022

I just used the bncs_client.py script to try and log on with an account that didn't exist to pvpgn.pro. The log gives me this:

INFO:BNCS:Client completed identification as WarCraft II: Battle.net Edition
DEBUG:BNCS:UDP test skipped - sending pre-configured value
INFO:BNCS:Logging into account 'chatbot' using OLS...
ERROR:BNCS:Account login failed - Account does not exist
INFO:BNCS:Creating account 'chatbot' using OLS...
INFO:BNCS:Successfully created account 'chatbot'
INFO:BNCS:Logging into account 'chatbot' using OLS...
ERROR:BNCS:Account login failed - Incorrect password
INFO:BNCS:Disconnected: dead

Subsequent attempts do not try to create the account, so it seems to now exist. So it seems while it created the account successfully, something is up with the double_hash_password function that prevents it from actually logging in with the (single hashed) password it submitted during account creation. Is there something I'm doing wrong?

For reference: Running python 3.10.0, compiled on Ubuntu Linux 20.04 x86_64)

@Davnit
Copy link
Owner

Davnit commented Feb 8, 2022

Weird, this seems to work fine on official Battle.net. PvPGN might be doing something weird, I'll have to look into it further.

@Davnit
Copy link
Owner

Davnit commented Feb 8, 2022

Hmm, when I connect to server.pvpgn.pro with the script, it's working for me. Is there anything extra special about your password? Does it happen with any password or just specific ones?

Davnit added a commit that referenced this issue Feb 10, 2022
Since the buffer is now of fixed size, checking its length for >0 would always yield True.

Might be related to #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants