Skip to content

Commit 3ea83bc

Browse files
Merge pull request #8 from DazedNConfused-/develop
Fixed built binaries startup problems for new Python version
2 parents fc7d244 + 257f20c commit 3ea83bc

File tree

4 files changed

+11
-6
lines changed

4 files changed

+11
-6
lines changed

BUILDING.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,10 @@ CDDA Game Launcher is developed using Python. In order to run or build the launc
88

99
The full list of requirements is available in [requirements.txt](requirements.txt). Most of these requirements are Python packages that can be installed using [pip](https://en.wikipedia.org/wiki/Pip_%28package_manager%29). Unfortunately, some of these requirements need build tools which are not easy to use nor easy to install on Windows. Here are those special requirements:
1010

11-
* lxml
1211
* pylzma
12+
* Microsoft C++ Build Tools
13+
* Windows 10 SDK
14+
* Inno Setup
1315

1416
Compiled binaries for lxml and pylzma can be found on [Christoph Gohlke's Unofficial Windows Binaries](http://www.lfd.uci.edu/~gohlke/pythonlibs/). If you are using Python >= 3.5, scandir should already be included. If you are using Python <= 3.4, you can also find compiled binaries for scandir on that website.
1517

cddagl/VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.6.0
1+
1.6.1

requirements.txt

166 Bytes
Binary file not shown.

setup.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,9 @@ def run_other_command(self, command_name, **kwargs):
6363
def include_requirements(target_path):
6464
# Install packages from requirements.txt file into build dir
6565
requirements_path = Path('requirements.txt')
66+
subprocess.run([
67+
'python', '-m', 'pip', 'install', '--upgrade', "pip"
68+
])
6669
subprocess.run([
6770
'python', '-m', 'pip', 'install', '-r', requirements_path,
6871
'--target', target_path
@@ -116,8 +119,8 @@ def run(self):
116119
download_path.mkdir(parents=True, exist_ok=True)
117120

118121
# Download Python embeddable package
119-
python_embed_url = 'https://www.python.org/ftp/python/3.9.0/python-3.9.0-embed-amd64.zip'
120-
python_embed_name = 'python-3.9.0-embed-amd64.zip'
122+
python_embed_url = 'https://www.python.org/ftp/python/3.9.7/python-3.9.7-embed-amd64.zip'
123+
python_embed_name = 'python-3.9.7-embed-amd64.zip'
121124

122125
python_embed_archive = download_path.joinpath(python_embed_name)
123126
try:
@@ -171,7 +174,7 @@ def run(self):
171174

172175
# Let's find and add unrar if available
173176
try:
174-
unrar_path = r'.\external-deps\unrar-command-line-tool\UnRAR.exe'
177+
unrar_path = r'.\third-party\unrar-command-line-tool\UnRAR.exe'
175178
shutil.copy(unrar_path, archive_dir_path)
176179
except CalledProcessError:
177180
log("'unrar.exe' couldn't be found.")
@@ -310,7 +313,7 @@ class CreateInnoSetupInstaller(ExtendedCommand):
310313
]
311314

312315
def initialize_options(self):
313-
self.compiler = r'.\external-deps\inno-setup\6.2.0\Compil32.exe'
316+
self.compiler = r'.\third-party\inno-setup\6.2.0\Compil32.exe'
314317

315318
def finalize_options(self):
316319
if not pathlib.Path(self.compiler).exists():

0 commit comments

Comments
 (0)