Core: Disable ScriptChunk Hook because it breaks things

Daztek · Daztek · commit 0740dc02c9c4 · 2019-10-30T17:30:37.000+01:00
diff --git a/Core/NWNXCore.cpp b/Core/NWNXCore.cpp
@@ -190,6 +190,7 @@ void NWNXCore::InitialSetupHooks()
                 }
             });
 
+    /* TODO-64Bit: This breaks stuff if it gets hooked, disabling it for now
     if (!m_coreServices->m_config->Get<bool>("ALLOW_NWNX_FUNCTIONS_IN_EXECUTE_SCRIPT_CHUNK", false))
     {
         m_services->m_hooks->RequestSharedHook<API::Functions::_ZN25CNWVirtualMachineCommands32ExecuteCommandExecuteScriptChunkEii, int32_t>(
@@ -198,6 +199,7 @@ void NWNXCore::InitialSetupHooks()
                     g_core->m_ScriptChunkRecursion += (type == Services::Hooks::CallType::BEFORE_ORIGINAL) ? +1 : -1;
                 });
     }
+    */
 
     // TODO-64Bit: Temp fix for POS
     m_services->m_hooks->RequestSharedHook<API::Functions::_ZN11CGameObjectC2Ehj, void>(

Original file line number	Diff line number	Diff line change
`@@ -190,6 +190,7 @@ void NWNXCore::InitialSetupHooks()`
`190`	`190`	`}`
`191`	`191`	`});`
`192`	`192`
	`193`	`+ /* TODO-64Bit: This breaks stuff if it gets hooked, disabling it for now`
`193`	`194`	`if (!m_coreServices->m_config->Get<bool>("ALLOW_NWNX_FUNCTIONS_IN_EXECUTE_SCRIPT_CHUNK", false))`
`194`	`195`	`{`
`195`	`196`	`m_services->m_hooks->RequestSharedHook<API::Functions::_ZN25CNWVirtualMachineCommands32ExecuteCommandExecuteScriptChunkEii, int32_t>(`
`@@ -198,6 +199,7 @@ void NWNXCore::InitialSetupHooks()`
`198`	`199`	`g_core->m_ScriptChunkRecursion += (type == Services::Hooks::CallType::BEFORE_ORIGINAL) ? +1 : -1;`
`199`	`200`	`});`
`200`	`201`	`}`
	`202`	`+ */`
`201`	`203`
`202`	`204`	`// TODO-64Bit: Temp fix for POS`
`203`	`205`	`m_services->m_hooks->RequestSharedHook<API::Functions::_ZN11CGameObjectC2Ehj, void>(`