Skip to content

Icon size in Quantity component is not correct #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
MARIEDELATTRE opened this issue Oct 28, 2022 · 1 comment
Closed
1 task done

Icon size in Quantity component is not correct #109

MARIEDELATTRE opened this issue Oct 28, 2022 · 1 comment
Assignees
@SimonLeclercq
Labels
android 🟢 Related to android bug 🐛 Something isn't working

Comments

@MARIEDELATTRE
Copy link
Contributor

Duplicates ❌

  • I have searched the existing issues

Which Figma library is concerned?

Vitamin Android UI Kit

Current behavior 😯

The icon size in quantity is 20px currently but we have changed icon size in icone alone button variants.
So we need tu change the icone in quantity from 20px to 24px (already done on web in ticket #101)

Expected behavior 🤔

No response

Context 🔦

No response

Screenshots / Videos 📸

No response
@MARIEDELATTRE MARIEDELATTRE added bug 🐛 Something isn't working android 🟢 Related to android run 💨 labels Oct 28, 2022
@lauthieb lauthieb changed the title Icon size in quantity Icon size in Quantity component is not correct Oct 28, 2022
@Sabrinavigil Sabrinavigil moved this from 🆕 New to 🔖 Ready to design in Decathlon Design System Nov 3, 2022
@SimonLeclercq SimonLeclercq self-assigned this Nov 3, 2022
@SimonLeclercq SimonLeclercq moved this from 🔖 Ready to design to 🏗 Design in progress in Decathlon Design System Nov 3, 2022
@SimonLeclercq SimonLeclercq moved this from 🏗 Design in progress to 👀 Design review in Decathlon Design System Nov 3, 2022
@MARIEDELATTRE MARIEDELATTRE moved this from 👀 Design review to 👍 Ready to dev in Decathlon Design System Nov 4, 2022
This was referenced Dec 5, 2022
Closed
Merged
Closed
@lauthieb
Copy link
Member

lauthieb commented Dec 5, 2022

Thanks @MARIEDELATTRE, this will be brought in these issues:

@lauthieb lauthieb closed this as completed Dec 5, 2022
Repository owner moved this from 👍 Ready to dev to ✅ Done in Decathlon Design System Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimonLeclercq SimonLeclercq

Labels
android 🟢 Related to android bug 🐛 Something isn't working
Projects
Decathlon Design System
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lauthieb @SimonLeclercq @MARIEDELATTRE