Add broken titles

Author: kiblik

docker-compose.override.unit_tests.yml

@@ -14,7 +14,7 @@ services:
       - "defectdojo_media_unit_tests:${DD_MEDIA_ROOT:-/app/media}"
     environment:
       PYTHONWARNINGS: error  # We are strict about Warnings during testing
-      DD_DEBUG: 'True'
+      # DD_DEBUG: 'True'
       DD_TEST_DATABASE_NAME: ${DD_TEST_DATABASE_NAME:-test_defectdojo}
       DD_DATABASE_NAME: ${DD_TEST_DATABASE_NAME:-test_defectdojo}
       DD_DATABASE_ENGINE: ${DD_DATABASE_ENGINE:-django.db.backends.postgresql}

docker/entrypoint-unit-tests-devDocker.sh

@@ -37,51 +37,51 @@ EOF
     exit 1
 }
 
-python3 manage.py migrate
+# python3 manage.py migrate
 
-# do the check with Django stack
-python3 manage.py check
+# # do the check with Django stack
+# python3 manage.py check
 
-python3 manage.py spectacular --fail-on-warn > /dev/null || {
-    cat <<-EOF
+# python3 manage.py spectacular --fail-on-warn > /dev/null || {
+#     cat <<-EOF
 
-********************************************************************************
+# ********************************************************************************
 
-You made changes to the REST API without applying the correct schema annotations
+# You made changes to the REST API without applying the correct schema annotations
 
-These schema annotations are needed to allow for the correct generation of
-the OpenAPI (v3) schema's and documentation.
+# These schema annotations are needed to allow for the correct generation of
+# the OpenAPI (v3) schema's and documentation.
 
-Review the warnings generated by drf-spectacular and see "dojo/api_v2/views.py"
-and/or "dojo/api_v2/serializers.py".
+# Review the warnings generated by drf-spectacular and see "dojo/api_v2/views.py"
+# and/or "dojo/api_v2/serializers.py".
 
-You can check for warnings locally by running
+# You can check for warnings locally by running
 
-     python3 manage.py spectacular > /dev/null
+#      python3 manage.py spectacular > /dev/null
 
-This will output only warnings/errors, or nothing if everything is OK.
+# This will output only warnings/errors, or nothing if everything is OK.
 
-More info at: https://drf-spectacular.readthedocs.io/en/latest/customization.html
+# More info at: https://drf-spectacular.readthedocs.io/en/latest/customization.html
 
-********************************************************************************
+# ********************************************************************************
 
-EOF
-    python3 manage.py spectacular > /dev/null
-}
+# EOF
+#     python3 manage.py spectacular > /dev/null
+# }
 
-echo "Unit Tests"
-echo "------------------------------------------------------------"
+# echo "Unit Tests"
+# echo "------------------------------------------------------------"
 
 # Removing parallel and shuffle for now to maintain stability
-python3 manage.py test unittests -v 3 --keepdb --no-input --exclude-tag="non-parallel" || {
-    exit 1;
-}
-python3 manage.py test unittests -v 3 --keepdb --no-input --tag="non-parallel" || {
-    exit 1;
-}
+# python3 manage.py test unittests -v 3 --keepdb --no-input --exclude-tag="non-parallel" || {
+#     exit 1;
+# }
+# python3 manage.py test unittests -v 3 --keepdb --no-input --tag="non-parallel" || {
+#     exit 1;
+# }
 
 # you can select a single file to "test" unit tests
-# python3 manage.py test unittests.tools.test_npm_audit_scan_parser.TestNpmAuditParser --keepdb -v 3
+python3 manage.py test unittests.test_notifications.TestNotificationWebhooks.test_events_messages --keepdb -v 3
 
 # or even a single method
 # python3 manage.py test unittests.tools.test_npm_audit_scan_parser.TestNpmAuditParser.test_npm_audit_parser_many_vuln_npm7 --keepdb -v 3

unittests/test_notifications.py

@@ -923,3 +923,56 @@ def test_events_messages(self, mock):
                     "url_ui": "http://localhost:8080/finding/235",
                 }],
             })
+
+        with self.subTest("scan_added problematic titles"):
+            BaseImporter(
+                environment=Development_Environment.objects.get_or_create(name="Development")[0],
+                scan_type="ZAP Scan",
+            ).notify_scan_added(
+                test,
+                updated_count=4,
+                new_findings=[
+                    Finding.objects.create(test=test, title="Colon: New Finding", severity="Critical"),
+                ],
+                findings_mitigated=[
+                    Finding.objects.create(test=test, title="[Brackets] Mitigated Finding", severity="Medium"),
+                ],
+                findings_reactivated=[
+                    Finding.objects.create(test=test, title='"Quotation1" Reactivated Finding', severity="Low"),
+                ],
+                findings_untouched=[
+                    Finding.objects.create(test=test, title="'Quotation2' Untouched Finding", severity="Info"),
+                ],
+            )
+            self.assertEqual(mock.call_args.kwargs["headers"]["X-DefectDojo-Event"], "scan_added")
+            self.maxDiff = None
+            self.assertEqual(mock.call_args.kwargs["json"]["findings"], {
+                "new": [{
+                    "id": 232,
+                    "title": "Colon: New Finding",
+                    "severity": "Critical",
+                    "url_api": "http://localhost:8080/api/v2/findings/232/",
+                    "url_ui": "http://localhost:8080/finding/232",
+                }],
+                "mitigated": [{
+                    "id": 233,
+                    "title": "[Brackets] Mitigated Finding",
+                    "severity": "Medium",
+                    "url_api": "http://localhost:8080/api/v2/findings/233/",
+                    "url_ui": "http://localhost:8080/finding/233",
+                }],
+                "reactivated": [{
+                    "id": 234,
+                    "title": "\"Quotation1\" Reactivated Finding",
+                    "severity": "Low",
+                    "url_api": "http://localhost:8080/api/v2/findings/234/",
+                    "url_ui": "http://localhost:8080/finding/234",
+                }],
+                "untouched": [{
+                    "id": 235,
+                    "title": "'Quotation2' Untouched Finding",
+                    "severity": "Info",
+                    "url_api": "http://localhost:8080/api/v2/findings/235/",
+                    "url_ui": "http://localhost:8080/finding/235",
+                }],
+            })