feat: private modifications

Author: Defelo

.github/workflows/build.yml

@@ -24,7 +24,7 @@ on:
         description: "Build on x86_64-darwin"
         required: true
         type: choice
-        default: yes_sandbox_relaxed
+        default: yes_sandbox_true
         options:
           - "no"
           - yes_sandbox_false
@@ -34,7 +34,7 @@ on:
         description: "Build on aarch64-darwin"
         required: true
         type: choice
-        default: yes_sandbox_relaxed
+        default: yes_sandbox_true
         options:
           - "no"
           - yes_sandbox_false

.github/workflows/check.yml

@@ -2,7 +2,7 @@ name: check
 
 on:
   push:
-    branches: [main]
+    branches: [main, private]
   pull_request:
 
 permissions:

.github/workflows/review.yml

@@ -27,7 +27,7 @@ on:
         description: "Run on x86_64-darwin"
         required: true
         type: choice
-        default: yes_sandbox_relaxed
+        default: yes_sandbox_true
         options:
           - "no"
           - yes_sandbox_false
@@ -37,7 +37,7 @@ on:
         description: "Run on aarch64-darwin"
         required: true
         type: choice
-        default: yes_sandbox_relaxed
+        default: yes_sandbox_true
         options:
           - "no"
           - yes_sandbox_false

shortcut.js

@@ -6,22 +6,76 @@
 
 const repo = "Defelo/nixpkgs-review-gha";
 
-const reviewDefaults = ({ title, commits, labels, author, authoredByMe, hasLinuxRebuilds, hasDarwinRebuilds }) => {
-  const darwinSandbox = "relaxed";
+const reviewDefaults = ({
+  title,
+  commits,
+  labels,
+  author,
+  authoredByMe,
+  hasLinuxRebuilds,
+  hasDarwinRebuilds,
+  state,
+}) => {
+  const darwinSandboxFalseList = ["miniserve", "radicle-ci-broker"];
+  const darwinSandboxRelaxedList = ["jujutsu", "smtp4dev"];
+  const x8664DarwinSkipList = [];
+
+  const testMap = [[["radicle-ci-broker", "radicle-native-ci", "radicle-job"], "nixosTests.radicle-ci-broker"]];
+  const testPackages = [
+    "alertmanager-ntfy",
+    "anubis",
+    "chhoto-url",
+    "echoip",
+    "glitchtip",
+    "go-httpbin",
+    "olivetin",
+    "privatebin",
+    "radicle-node",
+    "taplo",
+    "uiua",
+    "uiua-unstable",
+    "whoami",
+    "zipline",
+  ];
+
+  const skipMap = [[["taplo"], "servo"]];
+
+  const pkgsChanged = pkgs => pkgs.some(p => commits.some(({ subject }) => subject.startsWith(`${p}:`)));
+
+  const extraPkgs = new Set(
+    testMap
+      .filter(([pkgs]) => pkgsChanged(pkgs))
+      .map(([, test]) => test)
+      .concat(testPackages.filter(pkg => pkgsChanged([pkg])).map(pkg => `${pkg}.tests`)),
+  );
+
+  const skipPkgs = new Set(
+    skipMap.filter(([pkgs, skip]) => pkgsChanged(pkgs) && !pkgsChanged([skip])).map(([, skip]) => skip),
+  );
+
+  const darwinSandbox = pkgsChanged(darwinSandboxFalseList)
+    ? "false"
+    : pkgsChanged(darwinSandboxRelaxedList)
+      ? "relaxed"
+      : true;
 
   const hasRebuilds = hasLinuxRebuilds || hasDarwinRebuilds;
 
   return {
-    // "branch": "main",
+    branch: "private",
     "x86_64-linux": !hasRebuilds || hasLinuxRebuilds,
     "aarch64-linux": !hasRebuilds || hasLinuxRebuilds,
-    "x86_64-darwin": !hasRebuilds || hasDarwinRebuilds ? `yes_sandbox_${darwinSandbox}` : "no",
+    "x86_64-darwin":
+      !hasRebuilds || (hasDarwinRebuilds && !pkgsChanged(x8664DarwinSkipList)) ? `yes_sandbox_${darwinSandbox}` : "no",
     "aarch64-darwin": !hasRebuilds || hasDarwinRebuilds ? `yes_sandbox_${darwinSandbox}` : "no",
-    // "extra-args": "",
+    "extra-args": [...extraPkgs]
+      .map(pkg => `-a ${pkg}`)
+      .concat([...skipPkgs].map(pkg => `--skip-package ${pkg}`))
+      .join(" "),
     // "push-to-cache": true,
     // "upterm": false,
     // "post-result": true,
-    // "on-success": "nothing",
+    "on-success": state === "DRAFT" ? "mark_as_ready" : "nothing",
   };
 };