Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VULNERABILITY_COMMENT role #4744

Open
2 tasks done
dshafranskiy-r7 opened this issue Mar 11, 2025 · 2 comments
Open
2 tasks done

Add VULNERABILITY_COMMENT role #4744

dshafranskiy-r7 opened this issue Mar 11, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@dshafranskiy-r7
Copy link

Current Behavior

Currently there is only one Permission VULNERABILITY_ANALYSIS when it comes to handling vulnerabilities.
It includes Commenting out, Supressing and changing Triage status.

Proposed Behavior

As a big organization we would like to have a separation of duties when it comes to suppressing and setting vulnerabilities as False Positives.
Ideally there would be 2 different roles:

  • developer with VULNERABILITY_COMMENT role - who can comment out on the vulnerabilities (with proof why issue is FP or Service Now ticket number)
  • security team member with VULNERABILITY_ANALYSIS who would suppress and set those issues as FP's.

Request is to add new role that would not allow developer to change Vulnerability status but to comment out on vulnerabilities.

Checklist

@dshafranskiy-r7 dshafranskiy-r7 added the enhancement New feature or request label Mar 11, 2025
@VinodAnandan
Copy link
Contributor

Hi @dshafranskiy-r7 Thank you for raising this issue. It looks like a valuable feature! Would you be interested in contributing to its development?

@dshafranskiy-r7
Copy link
Author

dshafranskiy-r7 commented Mar 12, 2025

Hello @VinodAnandan definitely I can give a try.
Is there a Documentation Roles matrix that would reference scope for each role ?
Probably I would start from there.

Also should it utilize same method updateAnalysis and just limit update fields or extract to a separate method updateComment and extract that call to a new method ?

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants