Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json schema linting in CI #104

Closed
danihengeveld opened this issue Jun 20, 2024 · 2 comments
Closed

Json schema linting in CI #104

danihengeveld opened this issue Jun 20, 2024 · 2 comments

Comments

@danihengeveld
Copy link

It would be great if we could verify the value files against the json schema in CI.

This would enforce an up-to-date schema file for every change made to the charts.

Instead of creating an action for this ourselves I would recommend picking up this existing issue for the Validate Json Action first. When closed we can just use this.

OrRosenblatt/validate-json-action#26

@nscuro
Copy link
Member

nscuro commented Jun 20, 2024

JSON schema validation is already part of helm lint and helm install, you can see a validation failure during lint here: https://github.com/DependencyTrack/helm-charts/actions/runs/9599633812/job/26473974378

Is there anything beyond this that you'd like to see?

@danihengeveld
Copy link
Author

Oh, I was completely unaware of this, but that is a welcome surprise. Apologies.

Nothing else I can think of for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants