Skip to content

Commit

Permalink
Revert "Added support of per-extension assembly isolation (#1431)" (#…
Browse files Browse the repository at this point in the history
…1449)

This reverts commit 0fddec0.
  • Loading branch information
veler authored Nov 11, 2024
1 parent 0cb94b7 commit 453ffd1
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 34 deletions.
26 changes: 0 additions & 26 deletions src/app/dev/DevToys.Core/Mef/AssemblyIsolation.cs

This file was deleted.

9 changes: 1 addition & 8 deletions src/app/dev/DevToys.Core/Mef/RecursiveDirectoryCatalog.cs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ internal sealed partial class RecursiveDirectoryCatalog : ComposablePartCatalog,
{
private readonly ILogger _logger;
private readonly string _path;
private AssemblyIsolation? _assemblyIsolation;
private AggregateCatalog? _aggregateCatalog;

/// <summary>
Expand Down Expand Up @@ -123,13 +122,7 @@ private bool AddLibraryToMefCatalog(string filePath)
try
{
AssemblyCount++;

// Create an isolation context for the plugin.
// This allows to load dependencies version that the plugin asks, even if DevToys uses a different version of that same dependency.
_assemblyIsolation ??= new AssemblyIsolation(filePath);

Assembly assembly = _assemblyIsolation.LoadFromAssemblyPath(filePath);
var asmCat = new AssemblyCatalog(assembly);
var asmCat = new AssemblyCatalog(filePath);

// Force MEF to load the plugin and figure out if there are any exports
// good assemblies will not throw the RTLE exception and can be added to the catalog
Expand Down

0 comments on commit 453ffd1

Please sign in to comment.