-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add start date
option to createCertificate()
#30
Comments
start date
option to createCertificate()
@scaret its no bug of chrome, its if it were other than in chrome its a bug. tomorrow, i will look to fix add optional params to set a |
So it looks like the function With So you need also a "CA" config and some more data. https://www.openssl.org/docs/apps/ca#files So its a littlebit more work. |
@andris9 what do you think about it? |
Hey @Dexus would you be interested of taking over this project (I'd add you as a contributor and also as the npm package owner), so you could edit and publish the code directly? All the recent stuff is way more than I'll ever need or care for. |
Hey @andris9 yes i'm interested. I am on npmjs.org: dexus1985 Regards, Josef |
Ok, great! I added you as a collaborator to this repo and also as the npm package owner. So you can modify this repo and publish updates to npm at will. |
Thx. |
Looks like those PRs never made it into the repository? if it is a 2.0.0 thing because createCertificate needs to be rewritten, how soon could we hope for that? what if I submitted a PR? |
PR's are welcome and will be reviewed on our side before merging them. |
This is not implemented yet? 😢 |
When I type a URL in the browser and press Enter, the browser will try to connect to that host:port, and wait for a moment(several seconds); If there isn't a server at the beginning of "the moment", but a server manage to respond before the end of the timeout, the browser will accept it.
Since I have CA key/cert in my PC, I wrote a piece of code that will generate a certificate (according to its IP address), and use the certificate to start an HTTPS server. As in the case above, the request from the browser arrives before I generate the server certificate(and start the HTTPS server), but I can still respond to the request if the server can work in a very short time.
The browser will have a timestamp A when the request is sent, and the server will have a timestamp B when the certificate is signed(valid from). The problem is that, sometimes A is earlier than B, so browser will get a certificate error, given the info that the certificate has not taken into affect when you visit the website.
I think it may be a bug for the browser(Chrome), but it will be good if
pem
module can cover this by providing optionstartdate
.The text was updated successfully, but these errors were encountered: