Skip to content

Tidy up AllValvesControl #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
DominicOram opened this issue Feb 10, 2025 · 0 comments · May be fixed by #1058 or DiamondLightSource/i22-bluesky#118
Open

Tidy up AllValvesControl #1055

DominicOram opened this issue Feb 10, 2025 · 0 comments · May be fixed by #1058 or DiamondLightSource/i22-bluesky#118
Assignees
@barnettwilliam

Comments

@DominicOram
Copy link
Contributor

Currently, there is some complication in AllValvesControl around set_valve and types. We should simplify the interfaces along the lines of #1037 (review) and clean the interface up in line with #1031

Acceptance Criteria

  • The interface for valves in the pressure cell is simplified
  • Any plans that use this are updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barnettwilliam barnettwilliam

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@DominicOram @barnettwilliam