Skip to content

Log occassionally when waiting for XBPM feedback #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
DominicOram opened this issue Apr 17, 2025 · 1 comment · May be fixed by DiamondLightSource/dodal#1257
Open

Log occassionally when waiting for XBPM feedback #1003

DominicOram opened this issue Apr 17, 2025 · 1 comment · May be fixed by DiamondLightSource/dodal#1257
Assignees
@adaudon
Labels
good first issue Good for newcomers

Comments

@DominicOram
Copy link
Contributor

Because Hyperion is doing a number of things in parallel it is not always clar when it's waiting for the XBPM feedback. To make this clearer in the logs we should log whilst we are waiting for it, maybe with a diminishing frequency e.g. 1, 5, 30, 60 mins after.

Acceptance Criteria

  • We log periodically when we are waiting on xbpm feedback
@DominicOram DominicOram added the good first issue Good for newcomers label Apr 17, 2025
@DominicOram DominicOram moved this to Candidates for Next Sprint in Hyperion Apr 17, 2025
@DominicOram DominicOram moved this from Candidates for Next Sprint to Todo This Sprint in Hyperion Apr 28, 2025
@DominicOram
Copy link
Contributor Author

Probably cleanest way to do this is in the trigger of XBPMFeedback

@adaudon adaudon self-assigned this May 13, 2025
@DominicOram DominicOram moved this from Todo This Sprint to Blocked in Hyperion May 13, 2025
@DominicOram DominicOram moved this from Blocked to In Progress in Hyperion May 13, 2025
@adaudon adaudon linked a pull request Jun 3, 2025 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adaudon adaudon

Labels
good first issue Good for newcomers
Projects
Hyperion
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Waiting for xbpm feedback DiamondLightSource/dodal
2 participants
@DominicOram @adaudon